From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 3/3] drm/panel: add Kingdisplay kd097d04 panel driver Date: Tue, 10 Jul 2018 13:11:29 +0200 Message-ID: <20180710111129.GQ1504@ulmo> References: <20180702103229.3952-1-heiko@sntech.de> <20180702103229.3952-4-heiko@sntech.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0496500388==" Return-path: In-Reply-To: <20180702103229.3952-4-heiko@sntech.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, hl@rock-chips.com, briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nickey.yang@rock-chips.com, robh+dt@kernel.org List-Id: devicetree@vger.kernel.org --===============0496500388== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rKoHqF+aPLVth8b2" Content-Disposition: inline --rKoHqF+aPLVth8b2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 02, 2018 at 12:32:29PM +0200, Heiko Stuebner wrote: > From: Nickey Yang >=20 > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > it is a MIPI dual-DSI panel. >=20 > v2: > - update timing + cmds from chromeos kernel > - new backlight API including switch to devm_of_find_backlight > - fix most of Sean Paul's comments > enable/prepare tracking seems something all panels do > - document origins of the init sequence > - lanes per dsi interface to 4 (two interfaces). Matches how tegra > and pending rockchip dual-dsi handle (dual-)dsi lanes > - spdx header instead of license boilerplate >=20 > Signed-off-by: Nickey Yang > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/panel/Kconfig | 11 + > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-kingdisplay-kd097d04.c | 469 ++++++++++++++++++ > 3 files changed, 481 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c >=20 > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 25682ff3449a..9a0061f7fed7 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -68,6 +68,17 @@ config DRM_PANEL_JDI_LT070ME05000 > The panel has a 1200(RGB)=C3=971920 (WUXGA) resolution and uses > 24 bit per pixel. > =20 > +config DRM_PANEL_KINGDISPLAY_KD097D04 > + tristate "Kingdisplay kd097d04 panel" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y here if you want to enable support for Kingdisplay kd097d04 > + TFT-LCD modules. The panel has a 1536x2048 resolution and uses > + 24 bit RGB per pixel. It provides a MIPI DSI interface to > + the host and has a built-in LED backlight. > + > config DRM_PANEL_SAMSUNG_LD9040 > tristate "Samsung LD9040 RGB/SPI panel" > depends on OF && SPI > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makef= ile > index f26efc11d746..314b272f1e14 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -5,6 +5,7 @@ obj-$(CONFIG_DRM_PANEL_SIMPLE) +=3D panel-simple.o > obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) +=3D panel-ilitek-ili9322.o > obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) +=3D panel-innolux-p079zca.o > obj-$(CONFIG_DRM_PANEL_JDI_LT070ME05000) +=3D panel-jdi-lt070me05000.o > +obj-$(CONFIG_DRM_PANEL_KINGDISPLAY_KD097D04) +=3D panel-kingdisplay-kd09= 7d04.o > obj-$(CONFIG_DRM_PANEL_LG_LG4573) +=3D panel-lg-lg4573.o > obj-$(CONFIG_DRM_PANEL_ORISETECH_OTM8009A) +=3D panel-orisetech-otm8009a= =2Eo > obj-$(CONFIG_DRM_PANEL_PANASONIC_VVX10F034N00) +=3D panel-panasonic-vvx1= 0f034n00.o > diff --git a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c b/drivers= /gpu/drm/panel/panel-kingdisplay-kd097d04.c > new file mode 100644 > index 000000000000..9fc6b06fffee > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c > @@ -0,0 +1,469 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (c) 2017, Fuzhou Rockchip Electronics Co., Ltd > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +#include