* [PATCH] arm: dts: qcom: db410c: Fix Bluetooth LED trigger
@ 2018-06-11 13:18 Loic Poulain
2018-07-10 13:10 ` Loic Poulain
0 siblings, 1 reply; 4+ messages in thread
From: Loic Poulain @ 2018-06-11 13:18 UTC (permalink / raw)
To: andy.gross, david.brown, robh+dt; +Cc: linux-arm-msm, devicetree, Loic Poulain
Current LED trigger, 'bt', is not known/used by any existing driver.
Fix this by renaming it to 'bluetooth-power' trigger which is
controlled by the Bluetooth subsystem.
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 4c3dda5..16f6477 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -188,7 +188,7 @@
led@6 {
label = "apq8016-sbc:blue:bt";
gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "bt";
+ linux,default-trigger = "bluetooth-power";
default-state = "off";
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm: dts: qcom: db410c: Fix Bluetooth LED trigger
2018-06-11 13:18 [PATCH] arm: dts: qcom: db410c: Fix Bluetooth LED trigger Loic Poulain
@ 2018-07-10 13:10 ` Loic Poulain
2018-07-10 14:33 ` Niklas Cassel
0 siblings, 1 reply; 4+ messages in thread
From: Loic Poulain @ 2018-07-10 13:10 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring
Cc: linux-arm-msm, devicetree, Loic Poulain
Hi David, Andy,
On 11 June 2018 at 15:18, Loic Poulain <loic.poulain@linaro.org> wrote:
> Current LED trigger, 'bt', is not known/used by any existing driver.
> Fix this by renaming it to 'bluetooth-power' trigger which is
> controlled by the Bluetooth subsystem.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Any comments ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: dts: qcom: db410c: Fix Bluetooth LED trigger
2018-07-10 13:10 ` Loic Poulain
@ 2018-07-10 14:33 ` Niklas Cassel
2018-07-10 16:08 ` Andy Gross
0 siblings, 1 reply; 4+ messages in thread
From: Niklas Cassel @ 2018-07-10 14:33 UTC (permalink / raw)
To: Loic Poulain
Cc: Andy Gross, David Brown, Rob Herring, linux-arm-msm, devicetree
On Tue, Jul 10, 2018 at 03:10:58PM +0200, Loic Poulain wrote:
> Hi David, Andy,
>
> On 11 June 2018 at 15:18, Loic Poulain <loic.poulain@linaro.org> wrote:
> > Current LED trigger, 'bt', is not known/used by any existing driver.
> > Fix this by renaming it to 'bluetooth-power' trigger which is
> > controlled by the Bluetooth subsystem.
> >
> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Any comments ?
Hello Loic,
Perhaps a Fixes-tag would be nice here?
Kind regards,
Niklas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: dts: qcom: db410c: Fix Bluetooth LED trigger
2018-07-10 14:33 ` Niklas Cassel
@ 2018-07-10 16:08 ` Andy Gross
0 siblings, 0 replies; 4+ messages in thread
From: Andy Gross @ 2018-07-10 16:08 UTC (permalink / raw)
To: Niklas Cassel
Cc: Loic Poulain, David Brown, Rob Herring, linux-arm-msm, devicetree
On Tue, Jul 10, 2018 at 04:33:08PM +0200, Niklas Cassel wrote:
> On Tue, Jul 10, 2018 at 03:10:58PM +0200, Loic Poulain wrote:
> > Hi David, Andy,
> >
> > On 11 June 2018 at 15:18, Loic Poulain <loic.poulain@linaro.org> wrote:
> > > Current LED trigger, 'bt', is not known/used by any existing driver.
> > > Fix this by renaming it to 'bluetooth-power' trigger which is
> > > controlled by the Bluetooth subsystem.
> > >
> > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Any comments ?
>
> Hello Loic,
>
> Perhaps a Fixes-tag would be nice here?
Agreed, can you put a Fixes tag on this?
Andy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-10 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-11 13:18 [PATCH] arm: dts: qcom: db410c: Fix Bluetooth LED trigger Loic Poulain
2018-07-10 13:10 ` Loic Poulain
2018-07-10 14:33 ` Niklas Cassel
2018-07-10 16:08 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).