Re: [PATCH v5 05/22] dt-bindings: sram: sunxi: Populate valid sections compatibles

Chen-Yu Tsai
2018-07-10T14:47:07Z

On Tue, Jul 10, 2018 at 4:00 PM, Paul Kocialkowski
<paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> wrote:
> This adds a list of valid SRAM sections compatibles for the A13, A20,
> A23 and H3 platforms. Per-platform compatibles are introduced for the
> SRAM sections of these platforms, with the A10 compatibles also listed
> as valid when applicable.
>
> In particular, compatibles for the C1 SRAM section are introduced.

You should probably mention that this is not an exhaustive list. In
particular, the C2 and C3 (sun5i) mappings are still missing.

>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
> ---
> .../devicetree/bindings/sram/sunxi-sram.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sram/sunxi-sram.txt b/Documentation/devicetree/bindings/sram/sunxi-sram.txt
> index 156a02ab6b54..07c53c5214a0 100644
> --- a/Documentation/devicetree/bindings/sram/sunxi-sram.txt
> +++ b/Documentation/devicetree/bindings/sram/sunxi-sram.txt
> @@ -32,8 +32,33 @@ once again the representation described in the mmio-sram binding.
>
> The valid sections compatible for A10 are:
> - allwinner,sun4i-a10-sram-a3-a4
> + - allwinner,sun4i-a10-sram-c1
> - allwinner,sun4i-a10-sram-d
>
> +The valid sections compatible for A13 are:
> + - allwinner,sun5i-a13-sram-a3-a4
> + - allwinner,sun4i-a10-sram-a3-a4
> + - allwinner,sun5i-a13-sram-c1
> + - allwinner,sun4i-a10-sram-c1
> + - allwinner,sun5i-a13-sram-d
> + - allwinner,sun4i-a10-sram-d
> +
> +The valid sections compatible for A20 are:
> + - allwinner,sun7i-a20-sram-a3-a4
> + - allwinner,sun4i-a10-sram-a3-a4
> + - allwinner,sun7i-a20-sram-c1
> + - allwinner,sun4i-a10-sram-c1
> + - allwinner,sun7i-a20-sram-d
> + - allwinner,sun4i-a10-sram-d
> +
> +The valid sections compatible for A23/A33 are:
> + - allwinner,sun8i-a23-sram-c1
> + - allwinner,sun4i-a10-sram-c1
> +
> +The valid sections compatible for H3 are:
> + - allwinner,sun8i-h3-sram-c1
> + - allwinner,sun4i-a10-sram-c1

I'm not quite sure why we want to list these... I think it makes more sense
to just have the SoC specific compatible. They are tied to the controls
after all. Maybe Rob has a different opinion?

ChenYu

> +
> The valid sections compatible for A64 are:
> - allwinner,sun50i-a64-sram-c
>
> --
> 2.17.1
>