From: Brian Masney <masneyb@onstation.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: jic23@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
andy.gross@linaro.org, david.brown@linaro.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, jonathan@marek.ca,
jmaneyrol@invensense.com, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, mkelly@xevo.com, fischerdouglasc@gmail.com,
bshah@kde.org, ctatlor97@gmail.com
Subject: Re: [PATCH 2/3] iio: imu: mpu6050: add support for regulator framework
Date: Wed, 11 Jul 2018 06:31:29 -0400 [thread overview]
Message-ID: <20180711103129.ql4txni63i2m7m4r@d08157822050> (raw)
In-Reply-To: <20180711100442.GA30019@himanshu-Vostro-3559>
On Wed, Jul 11, 2018 at 03:34:43PM +0530, Himanshu Jha wrote:
> Hi Brain,
>
> On Tue, Jul 10, 2018 at 09:09:31PM -0400, Brian Masney wrote:
> > This patch adds support for the regulator framework to the mpu6050
> > driver.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> > Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> > ---
> > }
> > EXPORT_SYMBOL_GPL(inv_mpu_core_probe);
> >
> > +int inv_mpu_core_remove(struct inv_mpu6050_state *st)
> > +{
> > + return regulator_disable(st->vddio_supply);
> > +}
> EXPORT_SYMBOL_GPL(inv_mpu_core_remove); ?
>
> This is causing 0-day test build failure perhaps.
You are right. It compiles if I have CONFIG_INV_MPU6050_IIO built into
the kernel, which is what I'm using to boot the board, but fails when
compiled as a module. Good catch 0-day!
The patch won't apply to Linus's current master branch and I assumed
that iio/togreg didn't have the required changes as well. Sorry about
the noise.
I'll send a v2 before the weekend.
Brian
next prev parent reply other threads:[~2018-07-11 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 1:09 [PATCH 0/3] ARM: dts: qcom: msm8974-hammerhead: add support for mpu6515 Brian Masney
2018-07-11 1:09 ` [PATCH 1/3] iio: imu: mpu6050: add support for 6515 variant Brian Masney
2018-07-12 14:47 ` Jonathan Cameron
2018-07-15 8:41 ` Jonathan Cameron
2018-07-11 1:09 ` [PATCH 2/3] iio: imu: mpu6050: add support for regulator framework Brian Masney
2018-07-11 8:50 ` kbuild test robot
2018-07-11 9:07 ` Brian Masney
2018-07-11 10:04 ` Himanshu Jha
2018-07-11 10:31 ` Brian Masney [this message]
2018-07-11 12:29 ` Jean-Baptiste Maneyrol
2018-07-11 13:00 ` Brian Masney
2018-07-12 14:45 ` Jonathan Cameron
2018-07-11 1:09 ` [PATCH 3/3] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for mpu6515 Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711103129.ql4txni63i2m7m4r@d08157822050 \
--to=masneyb@onstation.org \
--cc=andy.gross@linaro.org \
--cc=bshah@kde.org \
--cc=ctatlor97@gmail.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fischerdouglasc@gmail.com \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=jmaneyrol@invensense.com \
--cc=jonathan@marek.ca \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkelly@xevo.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).