From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/4] dt-bindings: add binding for Allwinner R40 SATA AHCI controller Date: Wed, 11 Jul 2018 13:12:52 -0600 Message-ID: <20180711191252.GA2289@rob-hp-laptop> References: <1531149658-27030-1-git-send-email-clabbe@baylibre.com> <1531149658-27030-2-git-send-email-clabbe@baylibre.com> Reply-To: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1531149658-27030-2-git-send-email-clabbe-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Corentin Labbe Cc: linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Jul 09, 2018 at 03:20:55PM +0000, Corentin Labbe wrote: > From: Icenowy Zheng > > The Allwinner R40 SoC contains a SATA AHCI controller like the one in > A10/A20 SoCs, however a reset control and two power supplies are added > to it. > > Add a binding document for it. > > As a dedicated binding document is needed now for the A10/A20/R40 AHCI > controller, drop the A10 compatible line from generic platform AHCI > controller binding document. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/ata/ahci-platform.txt | 1 - > .../bindings/ata/allwinner,sun4i-a10-ahci.txt | 40 ++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt > > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt > index c760ecb81381..1bea4b5ef9fd 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt > @@ -9,7 +9,6 @@ PHYs. > > Required properties: > - compatible : compatible string, one of: > - - "allwinner,sun4i-a10-ahci" > - "brcm,iproc-ahci" > - "hisilicon,hisi-ahci" > - "cavium,octeon-7130-ahci" > diff --git a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt > new file mode 100644 > index 000000000000..0eea78c14ad3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt > @@ -0,0 +1,40 @@ > +Allwinner A10/A20/R40 SoC SATA AHCI Controller > + > +Required properties: > +- compatible : compatible string, one of: > + - "allwinner,sun4i-a10-ahci" > + - "allwinner,sun8i-r40-ahci" > +- interrupts : the SATA IRQ > +- reg : the register mapping > +- clocks : the clocks needed by SATA controller, usually contains > + an AHB clock and a mod clock usually? Need to specify the order. The examples look reversed of what you have here. > + > +Optional properties: > +- target-supply : regulator for SATA target power > + > +Required properties for the following compatibles: > + - "allwinner,sun8i-r40-ahci" > +- resets : the reset control needed by SATA controller > +- vdd1v2-supply : regulator for SATA controller's 1.2V VDD > +- vdd2v5-supply : regulator for SATA controller's 2.5V VDD > + > + > +Examples for A10: > + ahci: sata@1c18000 { > + compatible = "allwinner,sun4i-a10-ahci"; > + reg = <0x01c18000 0x1000>; > + interrupts = <56>; > + clocks = <&pll6 0>, <&ahb_gates 25>; > + target-supply = <®_ahci_5v>; > + }; > + > +Examples for R40: > + ahci: sata@1c18000 { > + compatible = "allwinner,sun8i-r40-ahci"; > + reg = <0x01c18000 0x1000>; > + interrupts = ; > + clocks = <&ccu CLK_SATA>, <&ccu CLK_BUS_SATA>; > + resets = <&ccu RST_BUS_SATA>; > + vdd1v2-supply = <®_eldo3>; > + vdd2v5-supply = <®_dldo4>; > + }; > -- > 2.16.4 >