From: Mark Brown <broonie@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
fabio.estevam@nxp.com, Anson.Huang@nxp.com,
kernel@pengutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding
Date: Fri, 13 Jul 2018 12:50:10 +0100 [thread overview]
Message-ID: <20180713115010.GA16228@sirena.org.uk> (raw)
In-Reply-To: <20180713083039.4z3ulwtg2ekx5n23@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Fri, Jul 13, 2018 at 10:30:39AM +0200, Marco Felsch wrote:
> On 18-07-12 16:31, Mark Brown wrote:
> > On Thu, Jul 12, 2018 at 01:02:39PM +0200, Marco Felsch wrote:
> > > +Optional properties:
> > > +- pfuze-disable-sw: Disable all unused switch regulators to save power
> > This is a bit of a confused way of specifying things that depends on the
> > Linux implementation, and the property sounds like a double negative
> > too. I'd say something like "pfuze-support-disable" and then explicitly
> > say that this is a workaround for backwards compatibility.
> I can't find the double negative. Anyway your binding sounds better. So
> I will use yours. Should we add a vendor prefix too to be clear? I will
> also add some more informations to mark it as workaround.
The property doesn't disable the use of switch regulators, it enables
their disabling. A vendor prefix is probably required but I can't
entirely follow the DT rules there, it certainly shouldn't hurt anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-07-13 11:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 11:02 [PATCH 0/2] Re-Enable support to disable switch regulators Marco Felsch
2018-07-12 11:02 ` [PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding Marco Felsch
2018-07-12 15:19 ` Fabio Estevam
2018-07-13 7:58 ` Marco Felsch
2018-07-12 15:31 ` Mark Brown
2018-07-13 8:30 ` Marco Felsch
2018-07-13 11:50 ` Mark Brown [this message]
2018-07-12 11:02 ` [PATCH 2/2] regulator: pfuze100: add support to en-/disable switch regulators Marco Felsch
2018-07-12 15:18 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713115010.GA16228@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).