From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [SPAM]Re: [PATCH v5 2/7] serdev: add dev_pm_domain_attach|detach() Date: Sun, 15 Jul 2018 10:12:10 +0200 Message-ID: <20180715081210.GB20758@kroah.com> References: <1531632595.26214.31.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1531632595.26214.31.camel@mtkswgap22> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sean Wang Cc: Mark Rutland , devicetree@vger.kernel.org, Ulf Hansson , Johan Hedberg , Rob Herring , Marcel Holtmann , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Sun, Jul 15, 2018 at 01:29:55PM +0800, Sean Wang wrote: > On Sat, 2018-07-14 at 18:27 +0200, Marcel Holtmann wrote: > > Hi Sean, > > > > > In order to open up the required power gate before any operation can be > > > effectively performed over the serial bus between CPU and serdev, it's > > > clearly essential to add common attach functions for PM domains to serdev > > > at the probe phase. > > > > > > Similarly, the relevant dettach function for the PM domains should be > > > properly and reversely added at the remove phase. > > > > > > Signed-off-by: Sean Wang > > > Reviewed-by: Ulf Hansson > > > Cc: Rob Herring > > > Cc: Ulf Hansson > > > Cc: Greg Kroah-Hartman > > > Cc: Jiri Slaby > > > Cc: linux-serial@vger.kernel.org > > > --- > > > drivers/tty/serdev/core.c | 15 ++++++++++++++- > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > can we take this through the serial subsystem? Or should I just take it when the driver is ready to be included? > > > > Regards > > > > Marcel > > > > I think it's better if the change is taken through serial subsystem > first. > > Hi, Rob > > do you have any comment? Yeah, I've been ignoring it to wait to get an ack from someone... greg k-h