From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: mark.rutland@arm.com, support@cubietech.com, linux@cubietech.com,
Saravanan Sekar <sravanhome@gmail.com>,
devicetree@vger.kernel.org, sboyd@kernel.org,
catalin.marinas@arm.com, mturquette@baylibre.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
thomas.liau@actions-semi.com, darren@cubietech.com,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
pn@denx.de, linux-clk@vger.kernel.org,
jeff.chen@actions-semi.com, mp-cs@actions-semi.com
Subject: Re: [PATCH v4 1/5] clk: actions: Add REGMAP as dependency
Date: Sun, 15 Jul 2018 19:45:51 +0530 [thread overview]
Message-ID: <20180715141551.GA9980@Mani-XPS-13-9360> (raw)
In-Reply-To: <b0e29fe8-c16a-e783-8877-d01f052ba963@suse.de>
Hi,
On Sun, Jul 15, 2018 at 02:35:53PM +0200, Andreas Färber wrote:
> Hi,
>
> Am 15.07.2018 um 14:31 schrieb Saravanan Sekar:
> > Add REGMAP as dependency to avoid undefined reference to regmap symbol
>
> Is this a bugfix for S900? Then please add a Fixes: line. If not, why is
> it a separate patch and not in 3/5?
>
Yes, this is a bug fix for S900 clk and should have Fixes tag.
Thanks,
Mani
> Also, the subject is fine as is, but please add a full stop at the end
> of the sentence in the commit message.
>
> Regards,
> Andreas
>
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-07-15 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 12:31 [PATCH v4 0/5] Add clock driver for Actions S700 SoC Saravanan Sekar
2018-07-15 12:31 ` [PATCH v4 1/5] clk: actions: Add REGMAP as dependency Saravanan Sekar
2018-07-15 12:35 ` Andreas Färber
2018-07-15 14:15 ` Manivannan Sadhasivam [this message]
2018-07-15 12:31 ` [PATCH v4 2/5] dt-bindings: clock: Add S700 support for Actions Semi Soc's Saravanan Sekar
2018-07-15 14:38 ` Manivannan Sadhasivam
2018-07-15 18:36 ` Andreas Färber
2018-07-15 12:31 ` [PATCH v4 3/5] clk: actions: Add S700 SoC clock support Saravanan Sekar
2018-07-15 14:44 ` Manivannan Sadhasivam
2018-07-15 12:31 ` [PATCH v4 4/5] arm64: dts: actions: Enable clock controller for S700 Saravanan Sekar
2018-07-15 14:51 ` Manivannan Sadhasivam
2018-07-15 12:31 ` [PATCH v4 5/5] arm64: dts: actions: Set UART clock reference from CMU Saravanan Sekar
2018-07-15 14:23 ` [PATCH v4 0/5] Add clock driver for Actions S700 SoC Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180715141551.GA9980@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=catalin.marinas@arm.com \
--cc=darren@cubietech.com \
--cc=devicetree@vger.kernel.org \
--cc=jeff.chen@actions-semi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@cubietech.com \
--cc=mark.rutland@arm.com \
--cc=mp-cs@actions-semi.com \
--cc=mturquette@baylibre.com \
--cc=pn@denx.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sravanhome@gmail.com \
--cc=support@cubietech.com \
--cc=thomas.liau@actions-semi.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox