From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 4/9] dt-bindings: ata: ahci-platform: document AHCI reset Date: Mon, 16 Jul 2018 09:54:16 -0600 Message-ID: <20180716155416.GA32497@rob-hp-laptop> References: <1531479786-4911-1-git-send-email-clabbe@baylibre.com> <1531479786-4911-5-git-send-email-clabbe@baylibre.com> Reply-To: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1531479786-4911-5-git-send-email-clabbe-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Corentin Labbe Cc: hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Jul 13, 2018 at 11:03:01AM +0000, Corentin Labbe wrote: > This patch document the new optional resets for ahci node. > > Signed-off-by: Corentin Labbe > --- > Documentation/devicetree/bindings/ata/ahci-platform.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt > index 5f362af2724c..a5281d7557e3 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt > @@ -34,6 +34,8 @@ Optional properties: > - phys : reference to the SATA PHY node > - phy-names : must be "sata-phy" > - ahci-supply : regulator for AHCI controller > +- resets : phandle to the reset line of AHCI controller > + If set, must have a reset-names set as "ahci" A name is pointless if there is only one. Also, the name should be what the signal in the block is called which I doubt would be called "ahci". A likely name is some form of reset, resetn, etc. which again is pointless to name if there is only 1. If you do have 'reset-names' then that needs to be listed too like phy-names. Rob