public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: usb-xhci: Add r8a77990 support
@ 2018-07-03 10:51 Yoshihiro Shimoda
  2018-07-13  7:28 ` Simon Horman
  2018-07-16 21:17 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2018-07-03 10:51 UTC (permalink / raw)
  To: mathias.nyman, gregkh, robh+dt, mark.rutland
  Cc: linux-usb, devicetree, linux-renesas-soc, Yoshihiro Shimoda

This patch adds r8a77990 xhci support. The driver will use
the fallback compatible string "renesas,rcar-gen3-xhci".

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 After we applied the following patches, the driver will use
the fallback compatible string "renesas,rcar-gen3-xhci" on
r8a77990. (If we doesn't apply the patches, the driver cannot
get the firmware name, and then the probe on r8a77990 failed.)

 https://patchwork.kernel.org/patch/10503777/
 https://patchwork.kernel.org/patch/10503781/

 Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index bd1dd31..ac4cd0d 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -14,6 +14,7 @@ Required properties:
     - "renesas,xhci-r8a7795" for r8a7795 SoC
     - "renesas,xhci-r8a7796" for r8a7796 SoC
     - "renesas,xhci-r8a77965" for r8a77965 SoC
+    - "renesas,xhci-r8a77990" for r8a77990 SoC
     - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
       device
     - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: usb-xhci: Add r8a77990 support
  2018-07-03 10:51 [PATCH] dt-bindings: usb-xhci: Add r8a77990 support Yoshihiro Shimoda
@ 2018-07-13  7:28 ` Simon Horman
  2018-07-16 21:17 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2018-07-13  7:28 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: mathias.nyman, gregkh, robh+dt, mark.rutland, linux-usb,
	devicetree, linux-renesas-soc

On Tue, Jul 03, 2018 at 07:51:47PM +0900, Yoshihiro Shimoda wrote:
> This patch adds r8a77990 xhci support. The driver will use
> the fallback compatible string "renesas,rcar-gen3-xhci".
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  After we applied the following patches, the driver will use
> the fallback compatible string "renesas,rcar-gen3-xhci" on
> r8a77990. (If we doesn't apply the patches, the driver cannot
> get the firmware name, and then the probe on r8a77990 failed.)
> 
>  https://patchwork.kernel.org/patch/10503777/
>  https://patchwork.kernel.org/patch/10503781/

Thanks.

FWIW I think we can still merge DTS patches to enable USB3 on E3 in
parallel with the above driver patches as enabling a device that was
previously not enabled won't cause a regression so long as the probe
failure doesn't cause other problems - f.e. kernel panic

> 
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index bd1dd31..ac4cd0d 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -14,6 +14,7 @@ Required properties:
>      - "renesas,xhci-r8a7795" for r8a7795 SoC
>      - "renesas,xhci-r8a7796" for r8a7796 SoC
>      - "renesas,xhci-r8a77965" for r8a77965 SoC
> +    - "renesas,xhci-r8a77990" for r8a77990 SoC
>      - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
>        device
>      - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: usb-xhci: Add r8a77990 support
  2018-07-03 10:51 [PATCH] dt-bindings: usb-xhci: Add r8a77990 support Yoshihiro Shimoda
  2018-07-13  7:28 ` Simon Horman
@ 2018-07-16 21:17 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-07-16 21:17 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: mathias.nyman, gregkh, mark.rutland, linux-usb, devicetree,
	linux-renesas-soc

On Tue, Jul 03, 2018 at 07:51:47PM +0900, Yoshihiro Shimoda wrote:
> This patch adds r8a77990 xhci support. The driver will use
> the fallback compatible string "renesas,rcar-gen3-xhci".
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  After we applied the following patches, the driver will use
> the fallback compatible string "renesas,rcar-gen3-xhci" on
> r8a77990. (If we doesn't apply the patches, the driver cannot
> get the firmware name, and then the probe on r8a77990 failed.)
> 
>  https://patchwork.kernel.org/patch/10503777/
>  https://patchwork.kernel.org/patch/10503781/
> 
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-16 21:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 10:51 [PATCH] dt-bindings: usb-xhci: Add r8a77990 support Yoshihiro Shimoda
2018-07-13  7:28 ` Simon Horman
2018-07-16 21:17 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox