From: Rob Herring <robh@kernel.org>
To: frowand.list@gmail.com
Cc: Alan Tull <atull@kernel.org>,
pantelis.antoniou@konsulko.com,
Pantelis Antoniou <panto@antoniou-consulting.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
geert@linux-m68k.org
Subject: Re: [PATCH] of: overlay: update phandle cache on overlay apply and remove
Date: Fri, 20 Jul 2018 09:06:50 -0600 [thread overview]
Message-ID: <20180720150650.GA32296@rob-hp-laptop> (raw)
In-Reply-To: <1531429207-3245-1-git-send-email-frowand.list@gmail.com>
On Thu, Jul 12, 2018 at 02:00:07PM -0700, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> A comment in the review of the patch adding the phandle cache said that
> the cache would have to be updated when modules are applied and removed.
> This patch implements the cache updates.
>
> Fixes: 0b3ce78e90fc ("of: cache phandle nodes to reduce cost of of_find_node_by_phandle()")
> Reported-by: Alan Tull <atull@kernel.org>
> Suggested-by: Alan Tull <atull@kernel.org>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
>
> Changes since RFC:
> - update code comment to mention race condition avoidance
>
> For the RFC version of this patch, the 0day test reported a general
> protection fault from the KASAN runtime memory debugger on x86_64
> in qemu. The GPF was in a devicetree unittest.
>
> 0day tested the patch on v4.17-rc1, with some other patches applied.
> I was unable to replicate the GPF on v4.18-rc1 with just this patch
> applied. I was also unable to replicate the GPF on a clone of the
> v4.17-rc1 0day repository, using the 0day kernel config. I will
> reply to this email with the 0day GPF report.
Didn't see any 0-day issues, so I've applied and it is in Linus' tree
now.
Rob
prev parent reply other threads:[~2018-07-20 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 21:00 [PATCH] of: overlay: update phandle cache on overlay apply and remove frowand.list
2018-07-12 21:08 ` Frank Rowand
2018-07-20 15:06 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720150650.GA32296@rob-hp-laptop \
--to=robh@kernel.org \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=panto@antoniou-consulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox