From: Rob Herring <robh@kernel.org>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/3] dt-bindings: arm: syna: add support for the AS370 SoC
Date: Fri, 20 Jul 2018 09:15:29 -0600 [thread overview]
Message-ID: <20180720151529.GA26487@rob-hp-laptop> (raw)
In-Reply-To: <20180713172457.6193a92f@xhacker.debian>
On Fri, Jul 13, 2018 at 05:24:57PM +0800, Jisheng Zhang wrote:
> The AS370 SoC is a new derivative of the berlin family. The only
> difference is the SoC isn't named as berlin*.
So is it a derivative or just rebranded?
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> Documentation/devicetree/bindings/arm/syna.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/syna.txt b/Documentation/devicetree/bindings/arm/syna.txt
> index 3bab18409b7a..3ba1d7b5ee74 100644
> --- a/Documentation/devicetree/bindings/arm/syna.txt
> +++ b/Documentation/devicetree/bindings/arm/syna.txt
> @@ -1,4 +1,4 @@
> -Marvell Berlin SoC Family Device Tree Bindings
> +Synaptics SoC Device Tree Bindings
Perhaps some note about what has happened here. Otherwise it looks
strange having "Marvell Berlin" in the document when the title says
Synaptics SoC.
> ---------------------------------------------------------------
>
> Work in progress statement:
> @@ -13,6 +13,10 @@ stable binding/ABI.
>
> ---------------------------------------------------------------
>
> +Boards with the Synaptics AS370 SoC shall have the following properties:
> + Required root node property:
> + compatible: "syna,as370"
> +
> Boards with a SoC of the Marvell Berlin family, e.g. Armada 1500
> shall have the following properties:
>
> --
> 2.18.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-20 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 9:17 [PATCH 0/3] arm64: dts: add Synaptics AS370 SoC support Jisheng Zhang
2018-07-13 9:18 ` [PATCH 1/3] dt-bindings: arm: move berlin binding documentation to syna.txt Jisheng Zhang
2018-07-20 15:12 ` Rob Herring
2018-07-13 9:24 ` [PATCH 2/3] dt-bindings: arm: syna: add support for the AS370 SoC Jisheng Zhang
2018-07-20 15:15 ` Rob Herring [this message]
2018-07-24 5:40 ` Jisheng Zhang
2018-07-13 9:26 ` [PATCH 3/3] arm64: dts: synaptics: add dtsi file for Synaptics " Jisheng Zhang
2018-07-20 15:21 ` Rob Herring
2018-07-24 5:58 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720151529.GA26487@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox