From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] irqchip: ingenic: Add support for the JZ4725B SoC
Date: Fri, 20 Jul 2018 09:31:31 -0600 [thread overview]
Message-ID: <20180720153131.GA14532@rob-hp-laptop> (raw)
In-Reply-To: <20180713144909.10657-1-paul@crapouillou.net>
On Fri, Jul 13, 2018 at 04:49:09PM +0200, Paul Cercueil wrote:
> The interrupt controller of the JZ4725B works the same way as the other
> JZ SoCs from Ingenic; so we just add a new compatible string.
This one too should have a fallback compatible and then the driver
change isn't needed.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> Documentation/devicetree/bindings/interrupt-controller/ingenic,intc.txt | 1 +
> drivers/irqchip/irq-ingenic.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ingenic,intc.txt b/Documentation/devicetree/bindings/interrupt-controller/ingenic,intc.txt
> index 5f89fb635a1b..f97fd8ab5e45 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/ingenic,intc.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/ingenic,intc.txt
> @@ -4,6 +4,7 @@ Required properties:
>
> - compatible : should be "ingenic,<socname>-intc". Valid strings are:
> ingenic,jz4740-intc
> + ingenic,jz4725b-intc
> ingenic,jz4770-intc
> ingenic,jz4775-intc
> ingenic,jz4780-intc
> diff --git a/drivers/irqchip/irq-ingenic.c b/drivers/irqchip/irq-ingenic.c
> index fc5953dea509..2ff08986b536 100644
> --- a/drivers/irqchip/irq-ingenic.c
> +++ b/drivers/irqchip/irq-ingenic.c
> @@ -165,6 +165,7 @@ static int __init intc_1chip_of_init(struct device_node *node,
> return ingenic_intc_of_init(node, 1);
> }
> IRQCHIP_DECLARE(jz4740_intc, "ingenic,jz4740-intc", intc_1chip_of_init);
> +IRQCHIP_DECLARE(jz4725b_intc, "ingenic,jz4725b-intc", intc_1chip_of_init);
>
> static int __init intc_2chip_of_init(struct device_node *node,
> struct device_node *parent)
> --
> 2.11.0
>
prev parent reply other threads:[~2018-07-20 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 14:49 [PATCH] irqchip: ingenic: Add support for the JZ4725B SoC Paul Cercueil
2018-07-20 15:31 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720153131.GA14532@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=paul@crapouillou.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox