From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs Date: Sat, 21 Jul 2018 13:56:04 -0500 Message-ID: <20180721185604.GI7404@hector.attlocal.net> References: <9f9cc23d1fd17503c9056d62f7757fb9c412d1f9.1527244201.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Amit Kucheria Cc: Viresh Kumar , arm@kernel.org, David Brown , Rob Herring , Mark Rutland , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-msm , "open list:ARM/QUALCOMM SUPPORT" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML List-Id: devicetree@vger.kernel.org On Wed, Jul 18, 2018 at 03:52:26PM +0530, Amit Kucheria wrote: > On Fri, May 25, 2018 at 4:02 PM, Viresh Kumar wrote: > > The OPP properties, like "operating-points", should either be present > > for all the CPUs of a cluster or none. If these are present only for a > > subset of CPUs of a cluster then things will start falling apart as soon > > as the CPUs are brought online in a different order. For example, this > > will happen because the operating system looks for such properties in > > the CPU node it is trying to bring up, so that it can create an OPP > > table. > > > > Add such missing properties. > > > > Fix other missing property (clock latency) as well to make it all > > work. > > > > Signed-off-by: Viresh Kumar > > FWIW, > Reviewed-by: Amit Kucheria Picking this up for 4.19. thanks. Andy