From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 2/5] ARM: dts: exynos: add pinctrl config for midas keys Date: Mon, 23 Jul 2018 19:12:52 +0200 Message-ID: <20180723171252.2z2sdetuan4snoq2@kozik-lap> References: <20180721125128.31498-1-simon@lineageos.org> <20180721125128.31498-3-simon@lineageos.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20180721125128.31498-3-simon@lineageos.org> Sender: linux-kernel-owner@vger.kernel.org To: Simon Shields Cc: linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Sat, Jul 21, 2018 at 10:50:50PM +1000, Simon Shields wrote: > This pins are externally pulled up, and so we should explicitly > configure them to disable the SoC-internal pull-downs. Previously > we relied on the bootloader doing this in order to allow the buttons > to function properly. > > Signed-off-by: Simon Shields > --- > arch/arm/boot/dts/exynos4412-midas.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) Thanks, applied. Best regards, Krzysztof