From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH 3/3] arm64: allwinner: dts: h6: add Wi-Fi support for Pine H64 model A/B Date: Wed, 25 Jul 2018 14:19:47 +0200 Message-ID: <20180725121947.ox4zykod6jjadvfw@flea> References: <20180724011551.49603-1-icenowy@aosc.io> <20180724011551.49603-4-icenowy@aosc.io> <20180724144151.myyg7slocsfjjsfi@flea> <198DB486-4789-4777-9596-2BD6FAFFB741@aosc.io> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bve3mvkgddeqoul3" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <198DB486-4789-4777-9596-2BD6FAFFB741-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Chen-Yu Tsai , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org --bve3mvkgddeqoul3 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 24, 2018 at 10:42:32PM +0800, Icenowy Zheng wrote: >=20 >=20 > =E4=BA=8E 2018=E5=B9=B47=E6=9C=8824=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88= 10:41:51, Maxime Ripard =E5=86=99=E5=88=B0: > >On Tue, Jul 24, 2018 at 10:37:51AM +0800, Chen-Yu Tsai wrote: > >> On Tue, Jul 24, 2018 at 10:28 AM, Icenowy Zheng > >wrote: > >> > > >> > > >> > =E4=BA=8E 2018=E5=B9=B47=E6=9C=8824=E6=97=A5 GMT+08:00 =E4=B8=8A=E5= =8D=8810:26:02, Chen-Yu Tsai =E5=86=99=E5=88=B0: > >> >>On Tue, Jul 24, 2018 at 10:23 AM, Icenowy Zheng > >> >>wrote: > >> >>> > >> >>> > >> >>> =E4=BA=8E 2018=E5=B9=B47=E6=9C=8824=E6=97=A5 GMT+08:00 =E4=B8=8A= =E5=8D=8810:21:59, Chen-Yu Tsai > >=E5=86=99=E5=88=B0: > >> >>>>On Tue, Jul 24, 2018 at 9:15 AM, Icenowy Zheng > >> >>wrote: > >> >>>>> The Pine H64 model A has a Wi-Fi module connector and the model > >B > >> >>has > >> >>>>an > >> >>>>> on-board RTL8723BS Wi-Fi module. > >> >>>>> > >> >>>>> Add support for them. For model A, as it's not defaultly > >present, > >> >>>>keep > >> >>>>> it disabled now. > >> >>>> > >> >>>>Nope. Pine64 actually has two WiFi/BT modules. And they require > >> >>>>different > >> >>>>device tree snippets for both the WiFi and BT side. This is > >better > >> >>>>resolved > >> >>>>with device tree overlays. > >> >>>> > >> >>>>I have both, though I've yet found time to work on them. > >> >>> > >> >>> I have also both. > >> >>> > >> >>> The skeleton here can get the Wi-Fi of both to work. > >> >> > >> >>Cool. Then I can put away my RTL module for now. :) > >> > > >> > P.S. SDIO is auto detectable, and for BCM chips, the OOB interrupt > >> > is only a bonus function and it can fall back to standard in-band > >> > interrupt (which doesn't need special binding, and is currently > >> > used by mainline r8723bs driver.) > >>=20 > >> Correct. With BT you'll have serdev device nodes with different > >> compatibles. Then you'll have to resort to overlays, and you'd > >probably > >> end up adding WiFi OOB interrupt bits as well. > >>=20 > >> So the question remaining is: should we enable the MMC part, along > >> with power sequencing and regulator supplies, by default? Thinking > >> more about it, I'm actually OK with it. The board connectors are > >> clearly marked as being for a WiFi+BT module. The whole space on > >> the board is surrounded by a box in silkscreen. Sorry for the > >> initial nack. > >>=20 > >> Maxime, any thoughts? > > > >If there's a need for an overlay anyway, there's no real reason to > >enable it by default, especially if not everything is there. >=20 > Everything is there, for model B support. Except BT? Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --bve3mvkgddeqoul3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAltYat0ACgkQ0rTAlCFN r3RXXQ/+O/j53xdIBK7aZHZSYYNGM4LbCT4+183lU8sEY+0FAx7O3mVqkRySnt0E Yxcyw47z+7C5YISHe/VSmSpZkFyhcVtLsxIILSKwchbJftAXQzoExsOt644LLcAK KzDb/DxJJPAMVH2G81IOmdZB1JHZvsKEKcYGF/1xbCGkq2gN0ro4vo0hx608Wdet 4HgEqtDFTLLQeiiPE+BgHO3OKW50tQoR+ayDUY2QwdmYR53hdzEiIXprRTnLG8Ck yVULQrl41UYY6VXOT5mLupuw2YICKRCHK9aNFG4P+4BRFfiOzPLORvLyOrUg3tur NlI1PzCT3DuBIspTu3kOCL+R6lQyqqXvYNQTdm/s5yV6ATa9/azafgpX9y+xRq7q V5SKXHCR2TMfm5XSCw3nGAgoowmXbTS9QVcqtrDUsBcSCblXcKyUnAn5UA0BGDZx uluG7vqkKzNt6LVCZctI2R/1euFIM0bxmer8JJ5YmkqhD+C/jqBDBpImQzzSflXl oJbS9bNYXtjtNyyhj8V9nA1fC9qid3aSSWvpJuBmdz7fZCDi0nGGnehYCuy35L7g iaN7pyjOx8CZZnq/PhCjZVrkPsKDRxNW/0hbhx01EvOUsvjpVAQ86qTdYEYrlYG6 HRMtvUp0RWk2NZQw99AJ237LtXreAO0+DlOkYgknG9LREsD4AAY= =LDtb -----END PGP SIGNATURE----- --bve3mvkgddeqoul3--