public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Vijay Viswanath <vviswana@codeaurora.org>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
	mark.rutland@arm.com, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com,
	linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org,
	devicetree@vger.kernel.org, asutoshd@codeaurora.org,
	stummala@codeaurora.org, venkatg@codeaurora.org,
	jeremymc@redhat.com, bjorn.andersson@linaro.org,
	riteshh@codeaurora.org, vbadigan@codeaurora.org,
	evgreen@chromium.org, dianders@google.com,
	sayalil@codeaurora.org
Subject: Re: [PATCH V1 2/3] Documentation: sdhci-msm: Add entries for passing load values
Date: Wed, 25 Jul 2018 11:55:22 -0600	[thread overview]
Message-ID: <20180725175522.GA10185@rob-hp-laptop> (raw)
In-Reply-To: <1532083566-43215-3-git-send-email-vviswana@codeaurora.org>

On Fri, Jul 20, 2018 at 04:16:05PM +0530, Vijay Viswanath wrote:
> The load a particular sdhc controller should request from a regulator
> is device specific and hence each device should individually vote for
> the required load.

"dt-bindings: mmc: ..." for the subject.

> 
> Signed-off-by: Vijay Viswanath <vviswana@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 502b3b8..ee34f28 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -26,6 +26,11 @@ Required properties:
>  	"cal"	- reference clock for RCLK delay calibration (optional)
>  	"sleep"	- sleep clock for RCLK delay calibration (optional)
>  
> +Optional properties:
> +- <supply>-current-level - specifies load levels for supply during BUS_ON
> +			and BUS_OFF states in power irq. Should be specified in
> +			pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively.
> +			Units uA.

This should probably be a common regulator property (or maybe one exists 
already).

It is missing vendor prefix and unit suffix as-is.

Rob

  reply	other threads:[~2018-07-25 17:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 10:46 [PATCH V1 0/3] Internal voltage control for platform drivers Vijay Viswanath
2018-07-20 10:46 ` [PATCH V1 1/3] mmc: sdhci: Allow platform controlled voltage switching Vijay Viswanath
2018-07-25 11:53   ` Adrian Hunter
2018-07-25 12:23     ` Vijay Viswanath
2018-07-25 12:37       ` Adrian Hunter
2018-07-20 10:46 ` [PATCH V1 2/3] Documentation: sdhci-msm: Add entries for passing load values Vijay Viswanath
2018-07-25 17:55   ` Rob Herring [this message]
2018-07-20 10:46 ` [PATCH V1 3/3] mmc: sdhci-msm: Use internal voltage control Vijay Viswanath
2018-07-25 14:04   ` Adrian Hunter
2018-09-18 11:35     ` Veerabhadrarao Badiganti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725175522.GA10185@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=asutoshd@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=evgreen@chromium.org \
    --cc=georgi.djakov@linaro.org \
    --cc=jeremymc@redhat.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=riteshh@codeaurora.org \
    --cc=sayalil@codeaurora.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbadigan@codeaurora.org \
    --cc=venkatg@codeaurora.org \
    --cc=vviswana@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox