* [PATCH] arm64: allwinner: dts: h6: fix Pine H64 MMC bus width
@ 2018-07-26 4:48 Icenowy Zheng
[not found] ` <20180726044805.55888-1-icenowy-h8G6r0blFSE@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Icenowy Zheng @ 2018-07-26 4:48 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-sunxi,
Icenowy Zheng
Currently the enabled MMC controllers on Pine H64 do not have bus-width
set, which make them fall back to 1-bit mode and become quite slow.
Fix this by add the corresponding bus-width properties.
Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine H64")
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index ceffc40810ee..48daec7f78ba 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -46,6 +46,7 @@
pinctrl-0 = <&mmc0_pins>;
vmmc-supply = <®_cldo1>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
+ bus-width = <4>;
status = "okay";
};
@@ -56,6 +57,7 @@
vqmmc-supply = <®_bldo2>;
non-removable;
cap-mmc-hw-reset;
+ bus-width = <8>;
status = "okay";
};
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: allwinner: dts: h6: fix Pine H64 MMC bus width
[not found] ` <20180726044805.55888-1-icenowy-h8G6r0blFSE@public.gmane.org>
@ 2018-07-30 8:27 ` Maxime Ripard
2018-08-20 14:24 ` Icenowy Zheng
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2018-07-30 8:27 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Chen-Yu Tsai, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Thu, Jul 26, 2018 at 12:48:05PM +0800, Icenowy Zheng wrote:
> Currently the enabled MMC controllers on Pine H64 do not have bus-width
> set, which make them fall back to 1-bit mode and become quite slow.
>
> Fix this by add the corresponding bus-width properties.
>
> Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine H64")
> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: allwinner: dts: h6: fix Pine H64 MMC bus width
2018-07-30 8:27 ` Maxime Ripard
@ 2018-08-20 14:24 ` Icenowy Zheng
[not found] ` <6e2df3d919b85f48c22c653124b7c2b594cb2d28.camel-h8G6r0blFSE@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Icenowy Zheng @ 2018-08-20 14:24 UTC (permalink / raw)
To: Maxime Ripard
Cc: devicetree, Chen-Yu Tsai, linux-sunxi, linux-kernel,
linux-arm-kernel
在 2018-07-30一的 10:27 +0200,Maxime Ripard写道:
> On Thu, Jul 26, 2018 at 12:48:05PM +0800, Icenowy Zheng wrote:
> > Currently the enabled MMC controllers on Pine H64 do not have bus-
> > width
> > set, which make them fall back to 1-bit mode and become quite slow.
> >
> > Fix this by add the corresponding bus-width properties.
> >
> > Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine
> > H64")
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>
> Applied, thanks!
BTW why didn't I see it in next-20180820?
It's 3 weeks later, and you didn't say that the patch is queued for
another version.
> Maxime
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: allwinner: dts: h6: fix Pine H64 MMC bus width
[not found] ` <6e2df3d919b85f48c22c653124b7c2b594cb2d28.camel-h8G6r0blFSE@public.gmane.org>
@ 2018-08-20 14:46 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2018-08-20 14:46 UTC (permalink / raw)
To: Icenowy Zheng
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Chen-Yu Tsai,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]
On Mon, Aug 20, 2018 at 10:24:20PM +0800, Icenowy Zheng wrote:
> 在 2018-07-30一的 10:27 +0200,Maxime Ripard写道:
> > On Thu, Jul 26, 2018 at 12:48:05PM +0800, Icenowy Zheng wrote:
> > > Currently the enabled MMC controllers on Pine H64 do not have bus-
> > > width
> > > set, which make them fall back to 1-bit mode and become quite slow.
> > >
> > > Fix this by add the corresponding bus-width properties.
> > >
> > > Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine
> > > H64")
> > > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
> >
> > Applied, thanks!
>
> BTW why didn't I see it in next-20180820?
>
> It's 3 weeks later, and you didn't say that the patch is queued for
> another version.
This has been merged to a fix branch we'll send for 4.19 once rc1 is
out.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-20 14:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26 4:48 [PATCH] arm64: allwinner: dts: h6: fix Pine H64 MMC bus width Icenowy Zheng
[not found] ` <20180726044805.55888-1-icenowy-h8G6r0blFSE@public.gmane.org>
2018-07-30 8:27 ` Maxime Ripard
2018-08-20 14:24 ` Icenowy Zheng
[not found] ` <6e2df3d919b85f48c22c653124b7c2b594cb2d28.camel-h8G6r0blFSE@public.gmane.org>
2018-08-20 14:46 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).