From: Boris Brezillon <boris.brezillon@bootlin.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
devicetree@vger.kernel.org, "Richard Weinberger" <richard@nod.at>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
"Jonas Gorski" <jonas.gorski@gmail.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Brian Norris" <computersforpeace@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH V2 1/2] dt-bindings: mtd: explicitly document nesting partitions descriptions
Date: Thu, 26 Jul 2018 21:42:58 +0200 [thread overview]
Message-ID: <20180726214258.733ca90d@bbrezillon> (raw)
In-Reply-To: <20180713143221.8474-1-zajec5@gmail.com>
On Fri, 13 Jul 2018 16:32:20 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Documentation was already saying that fixed and dynamic partitioning can
> be mixed but was missing a clear description and examples. This commit
> adds a proper documentation of how descriptions can be nested and how
> layouts can be mixed.
>
> This addition is important for partitions that contain subpartitions.
> In such cases partitions have to be properly described in order to let
> system handle them correctly.
>
> Depending on situation, nesting descriptions may provide more accurate
> logic/structure and/or allow mixing partitioning types (various
> "compatible" values).
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Applied both patches.
Thanks,
Boris
> ---
> V2: Rewrote example: I can include "brcm,trx" now as its Documentation
> has been pushed into mtd git tree.
> Updated commit message.
> ---
> .../devicetree/bindings/mtd/partition.txt | 46 ++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/partition.txt b/Documentation/devicetree/bindings/mtd/partition.txt
> index a8f382642ba9..afbbd870496d 100644
> --- a/Documentation/devicetree/bindings/mtd/partition.txt
> +++ b/Documentation/devicetree/bindings/mtd/partition.txt
> @@ -14,6 +14,13 @@ method is used for a given flash device. To describe the method there should be
> a subnode of the flash device that is named 'partitions'. It must have a
> 'compatible' property, which is used to identify the method to use.
>
> +When a single partition is represented with a DT node (it depends on a used
> +format) it may also be described using above rules ('compatible' and optionally
> +some extra properties / subnodes). It allows describing more complex,
> +hierarchical (multi-level) layouts and should be used if there is some
> +significant relation between partitions or some partition internally uses
> +another partitioning method.
> +
> Available bindings are listed in the "partitions" subdirectory.
>
>
> @@ -109,3 +116,42 @@ flash@2 {
> };
> };
> };
> +
> +flash@3 {
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "bootloader";
> + reg = <0x000000 0x100000>;
> + read-only;
> + };
> +
> + firmware@100000 {
> + label = "firmware";
> + reg = <0x100000 0xe00000>;
> + compatible = "brcm,trx";
> + };
> +
> + calibration@f00000 {
> + label = "calibration";
> + reg = <0xf00000 0x100000>;
> + compatible = "fixed-partitions";
> + ranges = <0 0xf00000 0x100000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "wifi0";
> + reg = <0x000000 0x080000>;
> + };
> +
> + partition@80000 {
> + label = "wifi1";
> + reg = <0x080000 0x080000>;
> + };
> + };
> + };
> +};
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2018-07-26 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 14:32 [PATCH V2 1/2] dt-bindings: mtd: explicitly document nesting partitions descriptions Rafał Miłecki
2018-07-13 14:32 ` [PATCH V2 2/2] mtd: partitions: use DT info for parsing partitions with "compatible" prop Rafał Miłecki
2018-07-16 17:57 ` [PATCH V2 1/2] dt-bindings: mtd: explicitly document nesting partitions descriptions Rob Herring
2018-07-26 19:42 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726214258.733ca90d@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).