From: Liviu Dudau <liviu.dudau@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org,
mike.leach@linaro.org, robert.walker@arm.com,
coresight@lists.linaro.org, robh@kernel.org,
frowand.list@gmail.com, devicetree@vger.kernel.org,
matt.sealey@arm.com, charles.garcia-tobin@arm.com,
john.horley@arm.com, al.grant@arm.com,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v3 9/9] dts: juno: Update coresight bindings
Date: Fri, 27 Jul 2018 11:17:52 +0100 [thread overview]
Message-ID: <20180727101752.GB28995@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <1532686537-12380-10-git-send-email-suzuki.poulose@arm.com>
On Fri, Jul 27, 2018 at 11:15:37AM +0100, Suzuki K Poulose wrote:
> Switch to updated coresight bindings for Juno platforms.
>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Looks good to me.
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> ---
> Changes since V2:
> - Update to new format.
> ---
> arch/arm64/boot/dts/arm/juno-base.dtsi | 161 +++++++++++++++---------------
> arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 52 ++++------
> arch/arm64/boot/dts/arm/juno.dts | 13 +--
> 3 files changed, 105 insertions(+), 121 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index ce56a4a..a418193 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -115,22 +115,17 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> - /* input port */
> - port@0 {
> - reg = <0>;
> + in-ports {
> + port {
> etf0_in_port: endpoint {
> - slave-mode;
> remote-endpoint = <&main_funnel_out_port>;
> };
> };
> + };
>
> - /* output port */
> - port@1 {
> - reg = <0>;
> + out-ports {
> + port {
> etf0_out_port: endpoint {
> };
> };
> @@ -144,10 +139,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - tpiu_in_port: endpoint {
> - slave-mode;
> - remote-endpoint = <&replicator_out_port0>;
> + in-ports {
> + port {
> + tpiu_in_port: endpoint {
> + remote-endpoint = <&replicator_out_port0>;
> + };
> };
> };
> };
> @@ -160,31 +156,29 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> - /* output port */
> - port@0 {
> - reg = <0>;
> + out-ports {
> + port {
> main_funnel_out_port: endpoint {
> remote-endpoint = <&etf0_in_port>;
> };
> };
> + };
>
> - /* input ports */
> - port@1 {
> + main_funnel_in_ports: in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> reg = <0>;
> main_funnel_in_port0: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster0_funnel_out_port>;
> };
> };
>
> - port@2 {
> + port@1 {
> reg = <1>;
> main_funnel_in_port1: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster1_funnel_out_port>;
> };
> };
> @@ -199,10 +193,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - etr_in_port: endpoint {
> - slave-mode;
> - remote-endpoint = <&replicator_out_port1>;
> + in-ports {
> + port {
> + etr_in_port: endpoint {
> + remote-endpoint = <&replicator_out_port1>;
> + };
> };
> };
> };
> @@ -216,8 +211,10 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - stm_out_port: endpoint {
> + out-ports {
> + port {
> + stm_out_port: endpoint {
> + };
> };
> };
> };
> @@ -238,9 +235,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - cluster0_etm0_out_port: endpoint {
> - remote-endpoint = <&cluster0_funnel_in_port0>;
> + out-ports {
> + port {
> + cluster0_etm0_out_port: endpoint {
> + remote-endpoint = <&cluster0_funnel_in_port0>;
> + };
> };
> };
> };
> @@ -252,29 +251,28 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> + out-ports {
> + port {
> cluster0_funnel_out_port: endpoint {
> remote-endpoint = <&main_funnel_in_port0>;
> };
> };
> + };
>
> - port@1 {
> + in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> reg = <0>;
> cluster0_funnel_in_port0: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster0_etm0_out_port>;
> };
> };
>
> - port@2 {
> + port@1 {
> reg = <1>;
> cluster0_funnel_in_port1: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster0_etm1_out_port>;
> };
> };
> @@ -297,9 +295,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - cluster0_etm1_out_port: endpoint {
> - remote-endpoint = <&cluster0_funnel_in_port1>;
> + out-ports {
> + port {
> + cluster0_etm1_out_port: endpoint {
> + remote-endpoint = <&cluster0_funnel_in_port1>;
> + };
> };
> };
> };
> @@ -320,9 +320,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - cluster1_etm0_out_port: endpoint {
> - remote-endpoint = <&cluster1_funnel_in_port0>;
> + out-ports {
> + port {
> + cluster1_etm0_out_port: endpoint {
> + remote-endpoint = <&cluster1_funnel_in_port0>;
> + };
> };
> };
> };
> @@ -334,43 +336,40 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> + out-ports {
> + port {
> cluster1_funnel_out_port: endpoint {
> remote-endpoint = <&main_funnel_in_port1>;
> };
> };
> + };
>
> - port@1 {
> + in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> reg = <0>;
> cluster1_funnel_in_port0: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster1_etm0_out_port>;
> };
> };
>
> - port@2 {
> + port@1 {
> reg = <1>;
> cluster1_funnel_in_port1: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster1_etm1_out_port>;
> };
> };
> - port@3 {
> + port@2 {
> reg = <2>;
> cluster1_funnel_in_port2: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster1_etm2_out_port>;
> };
> };
> - port@4 {
> + port@3 {
> reg = <3>;
> cluster1_funnel_in_port3: endpoint {
> - slave-mode;
> remote-endpoint = <&cluster1_etm3_out_port>;
> };
> };
> @@ -393,9 +392,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - cluster1_etm1_out_port: endpoint {
> - remote-endpoint = <&cluster1_funnel_in_port1>;
> + out-ports {
> + port {
> + cluster1_etm1_out_port: endpoint {
> + remote-endpoint = <&cluster1_funnel_in_port1>;
> + };
> };
> };
> };
> @@ -416,9 +417,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - cluster1_etm2_out_port: endpoint {
> - remote-endpoint = <&cluster1_funnel_in_port2>;
> + out-ports {
> + port {
> + cluster1_etm2_out_port: endpoint {
> + remote-endpoint = <&cluster1_funnel_in_port2>;
> + };
> };
> };
> };
> @@ -439,9 +442,11 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - port {
> - cluster1_etm3_out_port: endpoint {
> - remote-endpoint = <&cluster1_funnel_in_port3>;
> + out-ports {
> + port {
> + cluster1_etm3_out_port: endpoint {
> + remote-endpoint = <&cluster1_funnel_in_port3>;
> + };
> };
> };
> };
> @@ -454,7 +459,7 @@
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
>
> - ports {
> + out-ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -472,12 +477,10 @@
> remote-endpoint = <&etr_in_port>;
> };
> };
> -
> - /* replicator input port */
> - port@2 {
> - reg = <0>;
> + };
> + in-ports {
> + port {
> replicator_in_port0: endpoint {
> - slave-mode;
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> index 0c43fb3..cf28515 100644
> --- a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> @@ -7,23 +7,16 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - /* output port */
> - port@0 {
> - reg = <0>;
> + out-ports {
> + port {
> csys1_funnel_out_port: endpoint {
> remote-endpoint = <&etf1_in_port>;
> };
> };
> -
> - /* input port */
> - port@1 {
> - reg = <0>;
> + };
> + in-ports {
> + port {
> csys1_funnel_in_port0: endpoint {
> - slave-mode;
> };
> };
>
> @@ -37,22 +30,15 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - /* input port */
> - port@0 {
> - reg = <0>;
> + in-ports {
> + port {
> etf1_in_port: endpoint {
> - slave-mode;
> remote-endpoint = <&csys1_funnel_out_port>;
> };
> };
> -
> - /* output port */
> - port@1 {
> - reg = <0>;
> + };
> + out-ports {
> + port {
> etf1_out_port: endpoint {
> remote-endpoint = <&csys2_funnel_in_port1>;
> };
> @@ -67,20 +53,18 @@
> clocks = <&soc_smc50mhz>;
> clock-names = "apb_pclk";
> power-domains = <&scpi_devpd 0>;
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - /* output port */
> - port@0 {
> - reg = <0>;
> + out-ports {
> + port {
> csys2_funnel_out_port: endpoint {
> remote-endpoint = <&replicator_in_port0>;
> };
> };
> + };
>
> - /* input ports */
> - port@1 {
> + in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> reg = <0>;
> csys2_funnel_in_port0: endpoint {
> slave-mode;
> @@ -88,7 +72,7 @@
> };
> };
>
> - port@2 {
> + port@1 {
> reg = <1>;
> csys2_funnel_in_port1: endpoint {
> slave-mode;
> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
> index 2b2bf39..eb55c2f 100644
> --- a/arch/arm64/boot/dts/arm/juno.dts
> +++ b/arch/arm64/boot/dts/arm/juno.dts
> @@ -257,14 +257,11 @@
> remote-endpoint = <&main_funnel_in_port2>;
> };
>
> -&main_funnel {
> - ports {
> - port@3 {
> - reg = <2>;
> - main_funnel_in_port2: endpoint {
> - slave-mode;
> - remote-endpoint = <&stm_out_port>;
> - };
> +&main_funnel_in_ports {
> + port@2 {
> + reg = <2>;
> + main_funnel_in_port2: endpoint {
> + remote-endpoint = <&stm_out_port>;
> };
> };
> };
> --
> 2.7.4
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2018-07-27 10:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 10:15 [PATCH v3 0/9] coresight: Update device tree bindings Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 1/9] coresight: Document error handling in coresight_register Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 2/9] coresight: platform: Refactor graph endpoint parsing Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 3/9] coresight: platform: Fix refcounting for graph nodes Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 4/9] coresight: platform: Fix leaking device reference Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 5/9] coresight: Fix remote endpoint parsing Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 6/9] coresight: Add helper to check if the endpoint is input Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 7/9] coresight: platform: Cleanup coresight connection handling Suzuki K Poulose
2018-07-27 10:15 ` [PATCH v3 8/9] coresight: Cleanup coresight DT bindings Suzuki K Poulose
2018-07-30 23:13 ` Rob Herring
2018-07-27 10:15 ` [PATCH v3 9/9] dts: juno: Update coresight bindings Suzuki K Poulose
2018-07-27 10:17 ` Liviu Dudau [this message]
2018-07-30 23:14 ` Rob Herring
2018-07-30 20:02 ` [PATCH v3 0/9] coresight: Update device tree bindings Mathieu Poirier
2018-07-31 15:06 ` Mathieu Poirier
2018-09-10 15:35 ` Sudeep Holla
2018-09-10 15:49 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727101752.GB28995@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=al.grant@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=john.horley@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matt.sealey@arm.com \
--cc=mike.leach@linaro.org \
--cc=robert.walker@arm.com \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).