From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 30 Jul 2018 15:18:42 -0300 From: Mauro Carvalho Chehab Subject: Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support" Message-ID: <20180730151842.0fd99d01@coco.lan> In-Reply-To: <20180628162054.25613-19-m.felsch@pengutronix.de> References: <20180628162054.25613-1-m.felsch@pengutronix.de> <20180628162054.25613-19-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Marco Felsch Cc: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, p.zabel@pengutronix.de, afshin.nasser@gmail.com, javierm@redhat.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de List-ID: Em Thu, 28 Jun 2018 18:20:50 +0200 Marco Felsch escreveu: > From: Javier Martinez Canillas > > Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") > added input signals support for the tvp5150, but the approach was found > to be incorrect so the corresponding DT binding commit 82c2ffeb217a > ("[media] tvp5150: document input connectors DT bindings") was reverted. > > This left the driver with an undocumented (and wrong) DT parsing logic, > so lets get rid of this code as well until the input connectors support > is implemented properly. > > It's a partial revert due other patches added on top of mentioned commit > not allowing the commit to be reverted cleanly anymore. But all the code > related to the DT parsing logic and input entities creation are removed. > > Suggested-by: Laurent Pinchart > Signed-off-by: Javier Martinez Canillas > Acked-by: Laurent Pinchart > [m.felsch@pengutronix.de: rm TVP5150_INPUT_NUM define] > Signed-off-by: Marco Felsch > --- ... > -static int tvp5150_registered(struct v4l2_subdev *sd) > -{ > -#ifdef CONFIG_MEDIA_CONTROLLER > - struct tvp5150 *decoder = to_tvp5150(sd); > - int ret = 0; > - int i; > - > - for (i = 0; i < TVP5150_INPUT_NUM; i++) { > - struct media_entity *input = &decoder->input_ent[i]; > - struct media_pad *pad = &decoder->input_pad[i]; > - > - if (!input->name) > - continue; > - > - decoder->input_pad[i].flags = MEDIA_PAD_FL_SOURCE; > - > - ret = media_entity_pads_init(input, 1, pad); > - if (ret < 0) > - return ret; > - > - ret = media_device_register_entity(sd->v4l2_dev->mdev, input); > - if (ret < 0) > - return ret; > - > - ret = media_create_pad_link(input, 0, &sd->entity, > - DEMOD_PAD_IF_INPUT, 0); > - if (ret < 0) { > - media_device_unregister_entity(input); > - return ret; > - } > - } > -#endif Hmm... I suspect that reverting this part may cause problems for drivers like em28xx when compiled with MC, as they rely that the supported demods will have 3 pads (DEMOD_NUM_PADS). Thanks, Mauro