From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 8/9] coresight: Cleanup coresight DT bindings Date: Mon, 30 Jul 2018 17:13:56 -0600 Message-ID: <20180730231356.GA6353@rob-hp-laptop> References: <1532686537-12380-1-git-send-email-suzuki.poulose@arm.com> <1532686537-12380-9-git-send-email-suzuki.poulose@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1532686537-12380-9-git-send-email-suzuki.poulose@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, robert.walker@arm.com, coresight@lists.linaro.org, frowand.list@gmail.com, devicetree@vger.kernel.org, matt.sealey@arm.com, charles.garcia-tobin@arm.com, john.horley@arm.com, al.grant@arm.com, Sudeep Holla List-Id: devicetree@vger.kernel.org On Fri, Jul 27, 2018 at 11:15:36AM +0100, Suzuki K Poulose wrote: > The coresight drivers relied on default bindings for graph > in DT, while reusing the "reg" field of the "ports" to indicate > the actual hardware port number for the connections. This can > cause duplicate ports with same addresses, but different > direction. However, with the rules getting stricter for the > address mismatch with the label, it is no longer possible to use > the port address field for the hardware port number. > > This patch introduces new DT binding rules for coresight > components, based on the same generic DT graph bindings, but > avoiding the address duplication. > > - All output ports must be specified under a child node with > name "out-ports". > - All input ports must be specified under a childe node with > name "in-ports". > - Port address should match the hardware port number. > > The support for legacy bindings is retained, with a warning. > > Cc: Sudeep Holla > Cc: Rob Herring > Reviewed-by: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > .../devicetree/bindings/arm/coresight.txt | 95 ++++++++++++--------- Reviewed-by: Rob Herring > drivers/hwtracing/coresight/of_coresight.c | 98 +++++++++++++++++++--- > 2 files changed, 143 insertions(+), 50 deletions(-)