From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2] ARM: dts: sun8i: Add initial Orangepi Zero Plus 2 H3 support Date: Tue, 31 Jul 2018 16:16:22 +0200 Message-ID: <20180731141622.d3hvpfc5h74pwtgm@flea> References: <20180727125739.22871-1-diego.rondini@kynetics.com> <20180730115223.14161-1-diego.rondini@kynetics.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tomexo5ozpxwvilj" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20180730115223.14161-1-diego.rondini-WVsNeAwskfdWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Diego Rondini Cc: Rob Herring , Mark Rutland , Chen-Yu Tsai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jagan Teki List-Id: devicetree@vger.kernel.org --tomexo5ozpxwvilj Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Hi! On Mon, Jul 30, 2018 at 01:52:23PM +0200, Diego Rondini wrote: > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; > + status = "okay"; > +}; Like I said in the mail from a minute ago, we either want the serdev node, or no BT node at all and leave it for later. The rest looks fine, thanks! maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --tomexo5ozpxwvilj--