From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support Date: Tue, 31 Jul 2018 14:45:36 -0600 Message-ID: <20180731204536.GA7241@rob-hp-laptop> References: <20180727121806.18209-1-srinivas.kandagatla@linaro.org> <20180727121806.18209-4-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180727121806.18209-4-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Srinivas Kandagatla Cc: lee.jones@linaro.org, broonie@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, tiwai@suse.com, bgoswami@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, alsa-devel@alsa-project.org List-Id: devicetree@vger.kernel.org On Fri, Jul 27, 2018 at 01:17:59PM +0100, Srinivas Kandagatla wrote: > WCD9335 supports two lines of irqs INTR1 and INTR2. > Multiple interrupts are muxed via these lines. > INTR1 consists of all possible interrupt sources like: > Ear OCP, HPH OCP, MBHC, MAD, VBAT, and SVA > INTR2 is a subset of first interrupt sources like MAD, VBAT, and SVA > > Signed-off-by: Srinivas Kandagatla > --- > drivers/mfd/Makefile | 2 +- > drivers/mfd/wcd9335-core.c | 9 ++ > drivers/mfd/wcd9335-irq.c | 172 ++++++++++++++++++++++++++++++++++++ > include/dt-bindings/mfd/wcd9335.h | 43 +++++++++ I'm confused why these are defined here. The binding for the wc9335 is not an interrupt-controller. > include/linux/mfd/wcd9335/wcd9335.h | 3 + > 5 files changed, 228 insertions(+), 1 deletion(-) > create mode 100644 drivers/mfd/wcd9335-irq.c > create mode 100644 include/dt-bindings/mfd/wcd9335.h