From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/3] dt-bindings: interrupt-controller: Actions external interrupt controller Date: Tue, 31 Jul 2018 16:13:32 -0600 Message-ID: <20180731221332.GA29883@rob-hp-laptop> References: <20180724150219.1807724-1-pn@denx.de> <20180724150219.1807724-2-pn@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180724150219.1807724-2-pn@denx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Parthiban Nallathambi Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@cubietech.com, jason@lakedaemon.net, marc.zyngier@arm.com, catalin.marinas@arm.com, laisa.costa@lsitec.org.br, will.deacon@arm.com, linux-kernel@vger.kernel.org, thomas.liau@actions-semi.com, edgar.righi@lsitec.org.br, guilherme.simoes@lsitec.org.br, mp-cs@actions-semi.com, manivannan.sadhasivam@linaro.org, tglx@linutronix.de, mkzuffo@lsi.usp.br, afaerber@suse.de, linux-arm-kernel@lists.infradead.org, sravanhome@gmail.com List-Id: devicetree@vger.kernel.org On Tue, Jul 24, 2018 at 05:02:17PM +0200, Parthiban Nallathambi wrote: > Actions Semi OWL family SoC's provides support for external interrupt > controller to be connected and controlled using SIRQ pins. S500, S700 > and S900 provides 3 SIRQ lines and works independently for 3 external > interrupt controllers. > > Signed-off-by: Parthiban Nallathambi > Signed-off-by: Saravanan Sekar > --- > .../interrupt-controller/actions,owl-sirq.txt | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt > new file mode 100644 > index 000000000000..c5f8a29573c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt > @@ -0,0 +1,34 @@ > +Actions Semi Owl SoCs SIRQ interrupt controller > + > +S500, S700 and S900 SoC's from Actions provides interface, in which external > +interrupt controller can be connected. It has the following properties: > + > +- inputs three interrupt signal from external interrupt controller > + > +Required properties: > + > +- compatible: should be one of the following > + "actions,s700-sirq" > + "actions,s900-sirq" > +- reg: physical base address of the controller and length of memory mapped. > +- interrupt-controller: identifies the node as an interrupt controller > +- #interrupt-cells: specifies the number of cells needed to encode an interrupt > + source, should be 2. > +- interrupts: specifies the interrupt line in the interrupt controller and > + interrupt type (level or edge triggered) Need to state there are 3 interrupts. > +- sampling-rate-24m: this means the external controller's interrupts can be Needs a vendor prefix. > + sampled at 24MHz. Sampling can be specified for each SIRQ lines, as an array > + element. By default, all lines are sampled at 32KHz. > + > +Example: > + > +sirq: interrupt-controller@e01b0000 { > + compatible = "actions,s700-sirq"; > + reg = <0 0xe01b0000 0 0x1000>; > + interrupts = , > + , > + ; > + interrupt-controller; > + #interrupt-cells = <2>; > + sampling-rate-24m = <0 0 1>; > +}; > -- > 2.14.4 >