From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: kbuild-all@01.org, lee.jones@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, eballetbo@gmail.com,
linus.walleij@linaro.org, mazziesaccount@gmail.com,
dmitry.torokhov@gmail.com, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
sboyd@kernel.org, broonie@kernel.org,
linux-input@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com,
heikki.haikola@fi.rohmeurope.com
Subject: Re: [PATCH v11 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC
Date: Fri, 3 Aug 2018 14:05:11 +0300 [thread overview]
Message-ID: <20180803110511.GB20907@localhost.localdomain> (raw)
In-Reply-To: <201808031831.TJYSQ80i%fengguang.wu@intel.com>
On Fri, Aug 03, 2018 at 06:10:21PM +0800, kbuild test robot wrote:
> smatch warnings:
> drivers/mfd/rohm-bd718x7.c:163 bd71837_i2c_probe() warn: unsigned 'button.irq' is never less than zero.
>
> 160 button.irq = regmap_irq_get_virq(bd71837->irq_data,
> 161 BD71837_INT_PWRBTN_S);
> 162
> > 163 if (button.irq < 0) {
> 164 dev_err(&i2c->dev, "Failed to get the IRQ\n");
> 165 return button.irq;
> 166 }
Comparing unsiged to smaller-than-zero. These tools are handy! I'll fix
the errno check and send v12 in a minute... (or a bit more - but soonish
in any case =])
Br,
Matti Vaittinen
next prev parent reply other threads:[~2018-08-03 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 10:41 [PATCH v11 0/2] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver Matti Vaittinen
2018-07-30 10:43 ` [PATCH v11 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC Matti Vaittinen
2018-07-30 10:51 ` Matti Vaittinen
2018-08-02 8:35 ` Lee Jones
2018-08-03 10:10 ` kbuild test robot
2018-08-03 11:05 ` Matti Vaittinen [this message]
2018-07-30 10:46 ` [PATCH v11 2/2] mfd: bd71837: Devicetree bindings " Matti Vaittinen
2018-07-30 10:49 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803110511.GB20907@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=kbuild-all@01.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).