Re: [PATCH] rcar-csi2: add R8A77980 support

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

Hi Sergei,,

Thanks for your patch.

On 2018-08-06 19:56:27 +0300, Sergei Shtylyov wrote:
> Add the R-Car V3H (AKA R8A77980) SoC support to the R-Car CSI2 driver.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

It looks good but before I add my tag I would like to know if you tested 
this on a V3H? In the past extending the R-Car CSI-2 receiver to a new 
SoC always caught some new corner case :-)

I don't have access to a V3H myself otherwise I would of course test it 
myself.

> 
> ---
> This patch is against the 'media_tree.git' repo's 'master' branch.
> 
>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt |    1 
>  drivers/media/platform/rcar-vin/rcar-csi2.c                   |   11 ++++++++++
>  2 files changed, 12 insertions(+)
> 
> Index: media_tree/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> ===================================================================
> --- media_tree.orig/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ media_tree/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -12,6 +12,7 @@ Mandatory properties
>     - "renesas,r8a7796-csi2" for the R8A7796 device.
>     - "renesas,r8a77965-csi2" for the R8A77965 device.
>     - "renesas,r8a77970-csi2" for the R8A77970 device.
> +   - "renesas,r8a77980-csi2" for the R8A77980 device.
>  
>   - reg: the register base and size for the device registers
>   - interrupts: the interrupt for the device
> Index: media_tree/drivers/media/platform/rcar-vin/rcar-csi2.c
> ===================================================================
> --- media_tree.orig/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ media_tree/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -959,6 +959,13 @@ static const struct rcar_csi2_info rcar_
>  	.confirm_start = rcsi2_confirm_start_v3m_e3,
>  };
>  
> +static const struct rcar_csi2_info rcar_csi2_info_r8a77980 = {
> +	.init_phtw = rcsi2_init_phtw_h3_v3h_m3n,
> +	.hsfreqrange = hsfreqrange_h3_v3h_m3n,
> +	.csi0clkfreqrange = 0x20,
> +	.clear_ulps = true,
> +};
> +
>  static const struct of_device_id rcar_csi2_of_table[] = {
>  	{
>  		.compatible = "renesas,r8a7795-csi2",
> @@ -976,6 +983,10 @@ static const struct of_device_id rcar_cs
>  		.compatible = "renesas,r8a77970-csi2",
>  		.data = &rcar_csi2_info_r8a77970,
>  	},
> +	{
> +		.compatible = "renesas,r8a77980-csi2",
> +		.data = &rcar_csi2_info_r8a77980,
> +	},
>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, rcar_csi2_of_table);

-- 
Regards,
Niklas S�derlund