From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API [UNSCANNED] Date: Wed, 8 Aug 2018 10:59:05 +0100 Message-ID: <20180808095905.GG32322@imbe.wolfsonmicro.main> References: <1533557087-10401-1-git-send-email-stefan.popa@analog.com> <1533557087-10401-4-git-send-email-stefan.popa@analog.com> <20180806143901.GP2414@sirena.org.uk> <1533569985.11050.9.camel@analog.com> <20180806160402.GR2414@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180806160402.GR2414@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: "Popa, Stefan Serban" , "lars@metafoo.de" , "robh+dt@kernel.org" , "knaack.h@gmx.de" , "linux-kernel@vger.kernel.org" , "jic23@kernel.org" , "devicetree@vger.kernel.org" , "Hennerich, Michael" , "linux-iio@vger.kernel.org" , "mchehab+samsung@kernel.org" , "mark.rutland@arm.com" , "akpm@linux-foundation.org" , "pmeerw@pmeerw.net" , "gregkh@linuxfoundation.org" , "leonard.crestez@intel.com" , davem@davemlo List-Id: devicetree@vger.kernel.org On Mon, Aug 06, 2018 at 05:04:02PM +0100, Mark Brown wrote: > On Mon, Aug 06, 2018 at 03:39:53PM +0000, Popa, Stefan Serban wrote: > > On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > > > > I suggested having an explicit operation to check if a register supports > > > this mode of operation when I reviewed an earlier version, I didn't > > > notice a reply on that? > > > Sorry, I got confused about what needs to be done. Should I add a new field > > to the regmap_config struct which will be checked during the function call? > > Something like can_multi_write? How do you suggest it should be called? Is > > readable_noinc_reg ok? > > Like I said last time I'd suggest making it more like the readable and > volatile checks - I'm fairly sure I've seen devices that don't > autoincrement only for some registers. I can confirm I have seen hardware that autoincrements for some registers and not for others. Thanks, Charles