From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 8 Aug 2018 21:37:45 +0530 From: Vinod Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: Add binding for Qualcomm CCI I2C controller Message-ID: <20180808160745.GM2395@vkoul-mobl> References: <20180806110416.4288-1-vkoul@kernel.org> <20180806110416.4288-2-vkoul@kernel.org> <20180806180337.GB21235@tuxbook-pro> <20180807041826.GE2395@vkoul-mobl> <20180807173913.GA1567@rob-hp-laptop> <20180807180750.GR30024@minitux> <7a5076a6-9a63-8e13-24a5-e486f2b464cc@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Rob Herring Cc: Todor Tomov , Bjorn Andersson , Wolfram Sang , Linux I2C , linux-arm-msm , devicetree@vger.kernel.org List-ID: On 08-08-18, 08:48, Rob Herring wrote: > On Wed, Aug 8, 2018 at 8:03 AM Todor Tomov wrote: > > >>>> So this should either be: > > >>>> > > >>>> - "qcom,cci-v1.0.8" > > > > > > This is supposed to be 1.1.0 for 8916... > > > > There is conflicting information about this in the documentation. > > However the version read from the hw version register is 1.0.8 and > > this matches the value listed in the SWI too so I believe 1.0.8 is > > correct for 8916. > > And this is why we don't use version numbers. Unless you have access > to the RTL repositories with version tags then it is just error prone. Yeah we have a HW_VERSION register too, but someone might forget to populate it, so lets go ahead and use the soc numbers as discussed. Thanks -- ~Vinod