From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation Date: Wed, 8 Aug 2018 18:57:29 +0200 Message-ID: <20180808165729.GA6079@lst.de> References: <20180808150938.GA32274@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Marc Zyngier Cc: Christoph Hellwig , Rob Herring , Palmer Dabbelt , atish.patra@wdc.com, Thomas Gleixner , Jason Cooper , Mark Rutland , devicetree@vger.kernel.org, Albert Ou , Anup Patel , "linux-kernel@vger.kernel.org" , linux-riscv@lists.infradead.org, Stafford Horne List-Id: devicetree@vger.kernel.org On Wed, Aug 08, 2018 at 05:47:40PM +0100, Marc Zyngier wrote: > The original GIC driver deals with 2.5 revisions of the architecture > (yes, there was something pre-GICv1...), and implementers have been > creative to the extreme. Still, we could have done without most of these > compat strings. Hindsight and all that jazz. > > GICv3 is a much more controlled architecture, and although people have > come up with a number of turds masquerading as implementations, it has > never been bad enough to mandate a different set of compat strings. > Also, you cannot describe that kind of stuff in ACPI, and we need to > support both, so we've come up with different ways of handling this. So the claim from SiFive is that all their current plic blocks are the same. Based on that I'd be really tempted to just match for sifive,plic (or sifive,plic1 as suggested by them), but also require each device to actually provide a board specific compatible string, just in case that something goes wrong. Which I suspect is what you are doing with GICv3, right?