From: Lina Iyer <ilina@codeaurora.org>
To: Evan Green <evgreen@chromium.org>
Cc: marc.zyngier@arm.com, Stephen Boyd <sboyd@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
rplsssn@codeaurora.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
devicetree@vger.kernel.org, swboyd@chromium.org
Subject: Re: [PATCH RFC 4/4] arm64: dts: qcom: add wake up interrupts for GPIOs
Date: Wed, 8 Aug 2018 14:01:01 -0600 [thread overview]
Message-ID: <20180808200101.GD27850@codeaurora.org> (raw)
In-Reply-To: <CAE=gft5SRSnXN4Cs8JdTNgFKAFk1YH4bxL91=jvhRZe7Zznxdg@mail.gmail.com>
On Tue, Aug 07 2018 at 13:57 -0600, Evan Green wrote:
>On Tue, Jul 31, 2018 at 3:44 PM Lina Iyer <ilina@codeaurora.org> wrote:
>>
>> GPIOs that are wakeup capable have interrupt lines that are routed to
>> the always-on interrupt controller (PDC) in parallel to the pinctrl. The
>> interrupts listed here are the wake up lines corresponding to GPIOs.
>>
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 69 ++++++++++++++++++++++++++++
>> 1 file changed, 69 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index 8ccce42885c1..96ef18ced85b 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -720,6 +720,75 @@
>> #gpio-cells = <2>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> + interrupts-extended = <&pdc 30 IRQ_TYPE_LEVEL_HIGH>,
>
>In order to get any GPIO interrupts on my board, I needed to add the
>summary IRQ first in this list. My reading of platform_get_irq is that
>"interrupts-extended" is queried before "interrupts", so we
>accidentally wire the summary IRQ to PDC 30. Given this, you can
>probably remove the regular "interrupts" property.
>
Sure. Will fix that.
-- Lina
>> + <&pdc 31 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 32 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 33 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 34 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 35 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 36 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 37 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 38 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 39 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 41 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 42 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 43 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 44 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 45 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 46 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 47 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 49 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 50 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 51 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 52 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 54 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 55 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 56 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 57 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 58 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 59 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 60 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 61 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 62 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 63 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 64 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 65 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 66 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 67 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 68 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 69 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 70 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 71 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 72 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 73 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 74 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 75 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 76 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 77 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 79 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 80 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 81 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 82 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 83 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 84 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 85 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 86 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 90 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 91 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 92 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 95 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 96 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 97 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 98 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 99 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 102 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 103 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 104 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 105 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 106 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 107 IRQ_TYPE_LEVEL_HIGH>,
>> + <&pdc 108 IRQ_TYPE_LEVEL_HIGH>;
>>
>> qup_i2c0_default: qup-i2c0-default {
>> pinmux {
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
prev parent reply other threads:[~2018-08-08 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 22:44 [PATCH RFC 0/4] Wakeup GPIO support for SDM845 SoC Lina Iyer
2018-07-31 22:44 ` [PATCH RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO Lina Iyer
2018-07-31 22:44 ` [PATCH RFC 2/4] drivers: pinctrl: qcom: add wakeup gpio map for sdm845 Lina Iyer
2018-07-31 22:44 ` [PATCH RFC 3/4] arm64: dts: msm: add PDC device bindings " Lina Iyer
2018-07-31 22:44 ` [PATCH RFC 4/4] arm64: dts: qcom: add wake up interrupts for GPIOs Lina Iyer
2018-08-07 19:56 ` Evan Green
2018-08-08 20:01 ` Lina Iyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808200101.GD27850@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rnayak@codeaurora.org \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).