[PATCH v3 0/3] i2c: imx: Fix and enable DMA support for LS1021A

[PATCH v3 0/3] i2c: imx: Fix and enable DMA support for LS1021A

[Esben Haabendal]

From: Esben Haabendal <eha@deif.com>

This patch series fixes two race conditions and minor issues with tracking
the stopped state when something goes wrong.

With that in place, DMA support works with NXP LS1021A, so it is enabled in
the last patch.

Changes in v3:

* Rebased to v4.18-rc8, dropping patch 1/4 which have been merged
* Avoid unnecessary register write in patch 2/3
* Removed unneeded braces in patch 3/3

Changes in v2:

* Fixed speling mistake in commit message
* Rebased to v4.18-rc4

Esben Haabendal (3):
  i2c: imx: Fix race condition in dma read
  i2c: imx: Simplify stopped state tracking
  arm: dts: ls1021a: Enable I2C DMA support

 arch/arm/boot/dts/ls1021a.dtsi |  6 ++++++
 drivers/i2c/busses/i2c-imx.c   | 20 +++++++++-----------
 2 files changed, 15 insertions(+), 11 deletions(-)

-- 
2.18.0

[PATCH v3 3/3] arm: dts: ls1021a: Enable I2C DMA support

[Esben Haabendal]

From: Esben Haabendal <eha@deif.com>

Gives substantial performance improvement for transfers larger than 16
bytes (DMA_THRESHOLD).  Smaller transfers are unaffected.

Signed-off-by: Esben Haabendal <eha@deif.com>
---
 arch/arm/boot/dts/ls1021a.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index c55d479971cc..1e5640701c65 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -363,6 +363,8 @@
 			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "i2c";
 			clocks = <&clockgen 4 1>;
+			dma-names = "tx", "rx";
+			dmas = <&edma0 1 39>, <&edma0 1 38>;
 			status = "disabled";
 		};
 
@@ -374,6 +376,8 @@
 			interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "i2c";
 			clocks = <&clockgen 4 1>;
+			dma-names = "tx", "rx";
+			dmas = <&edma0 1 37>, <&edma0 1 36>;
 			status = "disabled";
 		};
 
@@ -385,6 +389,8 @@
 			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "i2c";
 			clocks = <&clockgen 4 1>;
+			dma-names = "tx", "rx";
+			dmas = <&edma0 1 35>, <&edma0 1 34>;
 			status = "disabled";
 		};
 
-- 
2.18.0

Re: [PATCH v3 0/3] i2c: imx: Fix and enable DMA support for LS1021A

[Esben Haabendal]

Esben Haabendal <esben.haabendal@gmail.com> writes:

> From: Esben Haabendal <eha@deif.com>
>
> This patch series fixes two race conditions and minor issues with tracking
> the stopped state when something goes wrong.
>
> With that in place, DMA support works with NXP LS1021A, so it is enabled in
> the last patch.
>
> Changes in v3:
>
> * Rebased to v4.18-rc8, dropping patch 1/4 which have been merged
> * Avoid unnecessary register write in patch 2/3
> * Removed unneeded braces in patch 3/3
>
> Changes in v2:
>
> * Fixed speling mistake in commit message
> * Rebased to v4.18-rc4
>
> Esben Haabendal (3):
>   i2c: imx: Fix race condition in dma read
>   i2c: imx: Simplify stopped state tracking
>   arm: dts: ls1021a: Enable I2C DMA support
>
>  arch/arm/boot/dts/ls1021a.dtsi |  6 ++++++
>  drivers/i2c/busses/i2c-imx.c   | 20 +++++++++-----------
>  2 files changed, 15 insertions(+), 11 deletions(-)

Uwe, will you take a look at this v3 of the series?  I made all changes
you requested with v2.

/Esben

Re: [PATCH v3 3/3] arm: dts: ls1021a: Enable I2C DMA support

[Shawn Guo]

On Thu, Aug 09, 2018 at 02:32:07PM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <eha@deif.com>
> 
> Gives substantial performance improvement for transfers larger than 16
> bytes (DMA_THRESHOLD).  Smaller transfers are unaffected.
> 
> Signed-off-by: Esben Haabendal <eha@deif.com>

Applied, thanks.