From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v6 11/24] watchdog: jz4740: Drop dependency on MACH_JZ47xx, use COMPILE_TEST Date: Fri, 10 Aug 2018 06:38:50 -0700 Message-ID: <20180810133850.GD29028@roeck-us.net> References: <20180809214414.20905-1-paul@crapouillou.net> <20180809214414.20905-12-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180809214414.20905-12-paul@crapouillou.net> Sender: linux-kernel-owner@vger.kernel.org To: Paul Cercueil Cc: Rob Herring , Mark Rutland , Thierry Reding , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Ralf Baechle , Paul Burton , James Hogan , Jonathan Corbet , Lee Jones , Mathieu Malaterre , Ezequiel Garcia , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-mips@linux-mips.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, Aug 09, 2018 at 11:44:01PM +0200, Paul Cercueil wrote: > Depending on MACH_JZ47xx prevent us from creating a generic kernel that > works on more than one MIPS board. Instead, we just depend on MIPS being > set. > > On other architectures, this driver can still be built, thanks to > COMPILE_TEST. This is used by automated tools to find bugs, for > instance. > > Signed-off-by: Paul Cercueil Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > v5: New patch > > v6: No change > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 834222abbbdb..13a46cfa69b0 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1475,7 +1475,7 @@ config INDYDOG > > config JZ4740_WDT > tristate "Ingenic jz4740 SoC hardware watchdog" > - depends on MACH_JZ4740 || MACH_JZ4780 > + depends on MIPS || COMPILE_TEST > depends on COMMON_CLK > select WATCHDOG_CORE > select INGENIC_TIMER > -- > 2.11.0 >