* [PATCH] powerpc/mpc85xx: fix issues in clock node
@ 2018-08-14 2:50 Yuantian Tang
0 siblings, 0 replies; 5+ messages in thread
From: Yuantian Tang @ 2018-08-14 2:50 UTC (permalink / raw)
To: robh+dt, mark.rutland; +Cc: devicetree, Yuantian Tang, paulus, linuxppc-dev
The compatible string is not correct in the clock node.
The clocks property refers to the wrong node too.
This patch is to fix them.
Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
---
arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
index 4908af5..763caf4 100644
--- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
@@ -348,7 +348,7 @@
mux0: mux0@0 {
#clock-cells = <0>;
reg = <0x0 4>;
- compatible = "fsl,core-mux-clock";
+ compatible = "fsl,qoriq-core-mux-2.0";
clocks = <&pll0 0>, <&pll0 1>;
clock-names = "pll0_0", "pll0_1";
clock-output-names = "cmux0";
@@ -356,9 +356,9 @@
mux1: mux1@20 {
#clock-cells = <0>;
reg = <0x20 4>;
- compatible = "fsl,core-mux-clock";
- clocks = <&pll0 0>, <&pll0 1>;
- clock-names = "pll0_0", "pll0_1";
+ compatible = "fsl,qoriq-core-mux-2.0";
+ clocks = <&pll1 0>, <&pll1 1>;
+ clock-names = "pll1_0", "pll1_1";
clock-output-names = "cmux1";
};
};
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] powerpc/mpc85xx: fix issues in clock node
@ 2018-09-11 2:12 andy.tang
2018-09-18 0:43 ` Andy Tang
2018-09-18 22:24 ` Scott Wood
0 siblings, 2 replies; 5+ messages in thread
From: andy.tang @ 2018-09-11 2:12 UTC (permalink / raw)
To: oss; +Cc: mark.rutland, devicetree, Yuantian Tang, robh+dt, linuxppc-dev
From: Yuantian Tang <andy.tang@nxp.com>
The compatible string is not correct in the clock node.
The clocks property refers to the wrong node too.
This patch is to fix them.
Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
---
arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
index 4908af5..763caf4 100644
--- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
@@ -348,7 +348,7 @@
mux0: mux0@0 {
#clock-cells = <0>;
reg = <0x0 4>;
- compatible = "fsl,core-mux-clock";
+ compatible = "fsl,qoriq-core-mux-2.0";
clocks = <&pll0 0>, <&pll0 1>;
clock-names = "pll0_0", "pll0_1";
clock-output-names = "cmux0";
@@ -356,9 +356,9 @@
mux1: mux1@20 {
#clock-cells = <0>;
reg = <0x20 4>;
- compatible = "fsl,core-mux-clock";
- clocks = <&pll0 0>, <&pll0 1>;
- clock-names = "pll0_0", "pll0_1";
+ compatible = "fsl,qoriq-core-mux-2.0";
+ clocks = <&pll1 0>, <&pll1 1>;
+ clock-names = "pll1_0", "pll1_1";
clock-output-names = "cmux1";
};
};
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/mpc85xx: fix issues in clock node
2018-09-11 2:12 andy.tang
@ 2018-09-18 0:43 ` Andy Tang
2018-09-18 22:24 ` Scott Wood
1 sibling, 0 replies; 5+ messages in thread
From: Andy Tang @ 2018-09-18 0:43 UTC (permalink / raw)
To: Andy Tang, oss@buserror.net
Cc: mark.rutland@arm.com, robh+dt@kernel.org,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org
Hi Scott,
Could you please take a look at this patch?
Thanks,
Andy
> -----Original Message-----
> From: andy.tang@nxp.com <andy.tang@nxp.com>
> Sent: 2018年9月11日 10:12
> To: oss@buserror.net
> Cc: robh+dt@kernel.org; mark.rutland@arm.com;
> benh@kernel.crashing.org; devicetree@vger.kernel.org;
> linuxppc-dev@lists.ozlabs.org; Andy Tang <andy.tang@nxp.com>
> Subject: [PATCH] powerpc/mpc85xx: fix issues in clock node
>
> From: Yuantian Tang <andy.tang@nxp.com>
>
> The compatible string is not correct in the clock node.
> The clocks property refers to the wrong node too.
> This patch is to fix them.
>
> Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> ---
> arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> index 4908af5..763caf4 100644
> --- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> @@ -348,7 +348,7 @@
> mux0: mux0@0 {
> #clock-cells = <0>;
> reg = <0x0 4>;
> - compatible = "fsl,core-mux-clock";
> + compatible = "fsl,qoriq-core-mux-2.0";
> clocks = <&pll0 0>, <&pll0 1>;
> clock-names = "pll0_0", "pll0_1";
> clock-output-names = "cmux0";
> @@ -356,9 +356,9 @@
> mux1: mux1@20 {
> #clock-cells = <0>;
> reg = <0x20 4>;
> - compatible = "fsl,core-mux-clock";
> - clocks = <&pll0 0>, <&pll0 1>;
> - clock-names = "pll0_0", "pll0_1";
> + compatible = "fsl,qoriq-core-mux-2.0";
> + clocks = <&pll1 0>, <&pll1 1>;
> + clock-names = "pll1_0", "pll1_1";
> clock-output-names = "cmux1";
> };
> };
> --
> 1.7.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/mpc85xx: fix issues in clock node
2018-09-11 2:12 andy.tang
2018-09-18 0:43 ` Andy Tang
@ 2018-09-18 22:24 ` Scott Wood
2018-09-19 6:31 ` Andy Tang
1 sibling, 1 reply; 5+ messages in thread
From: Scott Wood @ 2018-09-18 22:24 UTC (permalink / raw)
To: andy.tang; +Cc: mark.rutland, robh+dt, linuxppc-dev, devicetree
On Tue, 2018-09-11 at 10:12 +0800, andy.tang@nxp.com wrote:
> From: Yuantian Tang <andy.tang@nxp.com>
>
> The compatible string is not correct in the clock node.
> The clocks property refers to the wrong node too.
> This patch is to fix them.
>
> Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> ---
> arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> index 4908af5..763caf4 100644
> --- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> @@ -348,7 +348,7 @@
> mux0: mux0@0 {
> #clock-cells = <0>;
> reg = <0x0 4>;
> - compatible = "fsl,core-mux-clock";
> + compatible = "fsl,qoriq-core-mux-2.0";
> clocks = <&pll0 0>, <&pll0 1>;
> clock-names = "pll0_0", "pll0_1";
> clock-output-names = "cmux0";
> @@ -356,9 +356,9 @@
> mux1: mux1@20 {
> #clock-cells = <0>;
> reg = <0x20 4>;
> - compatible = "fsl,core-mux-clock";
> - clocks = <&pll0 0>, <&pll0 1>;
> - clock-names = "pll0_0", "pll0_1";
> + compatible = "fsl,qoriq-core-mux-2.0";
> + clocks = <&pll1 0>, <&pll1 1>;
> + clock-names = "pll1_0", "pll1_1";
> clock-output-names = "cmux1";
> };
> };
These are the legacy nodes. Why not just remove them instead of fixing them?
Now that the cpufreq driver is fixed we could get rid of the legacy nodes for
all the chips.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/mpc85xx: fix issues in clock node
2018-09-18 22:24 ` Scott Wood
@ 2018-09-19 6:31 ` Andy Tang
0 siblings, 0 replies; 5+ messages in thread
From: Andy Tang @ 2018-09-19 6:31 UTC (permalink / raw)
To: Scott Wood
Cc: mark.rutland@arm.com, robh+dt@kernel.org,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org
Hi Scott,
What you said makes sense well. I will resend the patch.
Thanks,
Andy
> -----Original Message-----
> From: Scott Wood <oss@buserror.net>
> Sent: 2018年9月19日 6:24
> To: Andy Tang <andy.tang@nxp.com>
> Cc: robh+dt@kernel.org; mark.rutland@arm.com;
> benh@kernel.crashing.org; devicetree@vger.kernel.org;
> linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] powerpc/mpc85xx: fix issues in clock node
>
> On Tue, 2018-09-11 at 10:12 +0800, andy.tang@nxp.com wrote:
> > From: Yuantian Tang <andy.tang@nxp.com>
> >
> > The compatible string is not correct in the clock node.
> > The clocks property refers to the wrong node too.
> > This patch is to fix them.
> >
> > Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> > ---
> > arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> > index 4908af5..763caf4 100644
> > --- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> > @@ -348,7 +348,7 @@
> > mux0: mux0@0 {
> > #clock-cells = <0>;
> > reg = <0x0 4>;
> > - compatible = "fsl,core-mux-clock";
> > + compatible = "fsl,qoriq-core-mux-2.0";
> > clocks = <&pll0 0>, <&pll0 1>;
> > clock-names = "pll0_0", "pll0_1";
> > clock-output-names = "cmux0";
> > @@ -356,9 +356,9 @@
> > mux1: mux1@20 {
> > #clock-cells = <0>;
> > reg = <0x20 4>;
> > - compatible = "fsl,core-mux-clock";
> > - clocks = <&pll0 0>, <&pll0 1>;
> > - clock-names = "pll0_0", "pll0_1";
> > + compatible = "fsl,qoriq-core-mux-2.0";
> > + clocks = <&pll1 0>, <&pll1 1>;
> > + clock-names = "pll1_0", "pll1_1";
> > clock-output-names = "cmux1";
> > };
> > };
>
> These are the legacy nodes. Why not just remove them instead of fixing
> them?
> Now that the cpufreq driver is fixed we could get rid of the legacy nodes
> for all the chips.
>
> -Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-19 6:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-14 2:50 [PATCH] powerpc/mpc85xx: fix issues in clock node Yuantian Tang
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 2:12 andy.tang
2018-09-18 0:43 ` Andy Tang
2018-09-18 22:24 ` Scott Wood
2018-09-19 6:31 ` Andy Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).