From: Rob Herring <robh@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Douglas Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
Varadarajan Narayanan <varada@codeaurora.org>
Subject: Re: [PATCH] dt-bindings: phy: qcom-qmp: Cleanup the 'reg' documentation as per review
Date: Tue, 14 Aug 2018 14:12:34 -0600 [thread overview]
Message-ID: <20180814201234.GA22842@rob-hp-laptop> (raw)
In-Reply-To: <20180807051412.126003-1-dianders@chromium.org>
On Mon, 6 Aug 2018 22:14:12 -0700, Douglas Anderson <dianders@chromium.org> wrote:
> After the commit 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to
> reflect reality") landed there was some review feedback that 'reg'
> should have been documented differently. Fix it as per review
> feedback.
>
> As per that feedback:
> - Subject should have been 'dt-bindings: phy:' which this patch now
> has.
> - We should leave no ambiguity in the ordering of 'reg' ranges even if
> 'reg-names' are also specified.
> - Normally using reg-names is discouraged unless there's a strong
> reason it's needed (like if there are optional ranges). In this
> case reg-names wasn't needed but the driver already landed relying
> on reg-names so we'll just document it and move on.
>
> Fixes: 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to reflect reality")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2018-08-14 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 5:14 [PATCH] dt-bindings: phy: qcom-qmp: Cleanup the 'reg' documentation as per review Douglas Anderson
2018-08-14 20:12 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814201234.GA22842@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=varada@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox