devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Peter Rosin <peda@axentia.se>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Linux PWM List <linux-pwm@vger.kernel.org>,
	Joshua Henderson <joshua.henderson@microchip.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Boris Brezillon <boris.brezillon@bootlin.com>,
	devicetree@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
	Lee Jones <lee.jones@linaro.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver
Date: Wed, 15 Aug 2018 22:48:15 +0200	[thread overview]
Message-ID: <20180815204815.GB29041@ravnborg.org> (raw)
In-Reply-To: <4def26df-0f4b-77e5-fea9-6c8f3537d831@axentia.se>

Hi Peter.

> 
> I stopped pushing that patch for reasons mentioned in
> https://lkml.org/lkml/2018/4/9/108
> 
> However, since then, the component approach mentioned in that mail was
> shot down and instead the tda998x driver is now a bridge (or soon, I expect
> the series from Russell King that to land in 4.19-rc1) which means that the
> binding from that series is back on the table. At least I guess so? However,
> in that series the approach is that the bridge states its expected input and
> the output then adjusts to what is needed. However, the "problem" is really in
> the atmel-hlcdc output (it moves the MSB for the RGB colors around depending
> on the output mode) so I no longer subscribe to all ideas in that series
> and think it is cleaner to state the needed bus format closer to the atmel-
> hlcdc endpoint as is done e.g. in this latest series:
> 
> https://lkml.org/lkml/2018/8/10/309
> 
> This latest series uses the media/video-interface approach and specifies
> the bus-width in the endpoint. However, the bus-width is alone obviously not
> enough to differentiate rgb565 and brg565, so will not help Sam
Some digging in diverse threads required.
I may take the easy way in v2 and postpone this feature.
But you all confirmed that doing something locally in the driver is the
wrong approach so that is ruled out.

> (or is it bgr565 that Sam needs? The above quoted text is ambiguous).
My bad. I need either rgb565 or bgr565 (at lest this is how I understood
the application note from Atmel/Microchip - need to re-read this too).

Some of the IP cores have an intensify bit which I do not yet understand
how to adapt to the supported formats. This is also on the todo list.

> I think something like my bus-format binding in [3] is generic enough to
> also help Sam.
Thanks, if I find time I will look into this, but first priority is to get the
bindinns correct, and then the overall structure of the driver.

	Sam

  reply	other threads:[~2018-08-15 20:48 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-12 18:41 [RFC PATCH 0/7] add at91sam9 LCDC DRM driver Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/ Sam Ravnborg
2018-08-14  8:39   ` Daniel Vetter
2018-08-14 16:19     ` Sam Ravnborg
2018-08-16  7:41       ` Daniel Vetter
2018-08-22 20:09         ` Sam Ravnborg
2018-08-22 20:22           ` Daniel Vetter
2018-08-24  8:28   ` Boris Brezillon
2018-08-24 15:43     ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 2/7] dt-binding: add bindings for Atmel LCDC mfd Sam Ravnborg
2018-08-24  8:45   ` Boris Brezillon
2018-08-24 15:58     ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 3/7] mfd: add atmel-lcdc driver Sam Ravnborg
2018-08-14 11:09   ` kbuild test robot
2018-08-15  5:24   ` Lee Jones
2018-08-15 20:40     ` Sam Ravnborg
2018-08-16  8:28       ` Nicolas Ferre
2018-08-16  8:42         ` Lee Jones
2018-08-24  8:37         ` Boris Brezillon
2018-08-24  8:15     ` Boris Brezillon
2018-08-24 10:58       ` Lee Jones
2018-08-15  8:11   ` kbuild test robot
2018-08-24  8:48   ` Boris Brezillon
2018-08-12 18:46 ` [PATCH v1 4/7] dt-bindings: add bindings for Atmel LCDC pwm Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 5/7] pwm: add pwm-atmel-lcdc driver Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 6/7] dt-bindings: add bindings for Atmel lcdc-display-controller Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 7/7] drm: add Atmel LCDC display controller support Sam Ravnborg
2018-08-24 12:31   ` Boris Brezillon
2018-08-26 18:41     ` Sam Ravnborg
2018-08-26 14:28   ` Noralf Trønnes
2018-08-26 14:58     ` Sam Ravnborg
2018-08-12 19:55 ` [RFC PATCH 0/7] add at91sam9 LCDC DRM driver Sam Ravnborg
2018-08-13 14:47   ` Nicolas Ferre
2018-08-14  8:41     ` Daniel Vetter
2018-08-22 20:12       ` Sam Ravnborg
2018-08-23  6:16         ` Daniel Vetter
2018-08-13 15:54 ` Nicolas Ferre
2018-08-13 18:18   ` Sam Ravnborg
2018-08-13 22:04     ` Rob Herring
2018-08-14 16:43       ` Sam Ravnborg
2018-08-14 22:42         ` Rob Herring
2018-08-15  4:48           ` Sam Ravnborg
2018-08-15 14:45             ` Rob Herring
2018-08-15 15:04               ` Daniel Vetter
2018-08-15 15:41                 ` Peter Rosin
2018-08-15 20:48                   ` Sam Ravnborg [this message]
2018-08-14 14:36     ` Alexandre Belloni
2018-08-14 16:16       ` Sam Ravnborg
2018-08-24  8:22 ` Boris Brezillon
2018-08-24 15:52   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180815204815.GB29041@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joshua.henderson@microchip.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).