From: Rob Herring <robh@kernel.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org, amstan@chromium.org,
groeck@google.com, kieran.bingham@ideasonboard.com,
kernel@collabora.com, bleung@chromium.org, heiko@sntech.de,
devicetree@vger.kernel.org,
Frank Wang <frank.wang@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties.
Date: Wed, 15 Aug 2018 16:21:57 -0600 [thread overview]
Message-ID: <20180815222157.GA8193@rob-hp-laptop> (raw)
In-Reply-To: <20180815095934.11205-3-enric.balletbo@collabora.com>
On Wed, Aug 15, 2018 at 11:59:32AM +0200, Enric Balletbo i Serra wrote:
> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for
> rk3399") introduces two new properties. The extcon property is used to
> detect the cable-state, and the rockchip,utmi-avalid is used to indicate
> which register should be used to detect the vbus state.
>
> Document these properties in the documentation binding.
>
> Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> index 074a7b3b0425..2d4808d3920b 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> @@ -23,6 +23,7 @@ Optional properties:
> register files". When set driver will request its
> phandle as one companion-grf for some special SoCs
> (e.g RV1108).
> + - extcon : phandle to the extcon device for the otg phy.
extcon is not a good binding. The usb connector binding should be used
instead for new users.
Rob
next prev parent reply other threads:[~2018-08-15 22:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 9:59 [PATCH 0/4] phy: rockchip-inno-usb2: document improvements and allow to force B-device valid session bit Enric Balletbo i Serra
2018-08-15 9:59 ` [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties Enric Balletbo i Serra
2018-08-15 10:29 ` Heiko Stuebner
2018-08-15 11:08 ` Enric Balletbo i Serra
2018-08-15 11:22 ` Heiko Stuebner
2018-08-15 22:21 ` Rob Herring [this message]
2018-08-16 8:38 ` Enric Balletbo i Serra
2018-08-15 9:59 ` [PATCH 4/4] dt-bindings: phy-rockchip-inno-usb2: add new rockchip,force-bvalid property Enric Balletbo i Serra
2018-08-15 10:34 ` Heiko Stuebner
2018-08-15 22:26 ` Rob Herring
2019-01-10 9:06 ` Enric Balletbo Serra
2019-01-10 12:31 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815222157.GA8193@rob-hp-laptop \
--to=robh@kernel.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=frank.wang@rock-chips.com \
--cc=groeck@google.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox