From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] Input: fix irqf_oneshot.cocci warnings Date: Thu, 16 Aug 2018 14:46:02 +0800 Message-ID: <20180816064602.GA95363@cairo> References: <662cd241e04a1e033c87d1a94c594740b594b0b6.1534384964.git.Roy.Im@diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <662cd241e04a1e033c87d1a94c594740b594b0b6.1534384964.git.Roy.Im@diasemi.com> Sender: linux-kernel-owner@vger.kernel.org To: Roy Im Cc: kbuild-all@01.org, Dmitry Torokhov , Rob Herring , Mark Rutland , Support Opensource , devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org From: kbuild test robot drivers/input/misc/da7280.c:1335:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Fixes: a067f5d53e35 ("Input: new da7280 haptic driver") CC: Roy Im Signed-off-by: kbuild test robot --- Please take the patch only if it's a positive warning. Thanks! da7280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/misc/da7280.c +++ b/drivers/input/misc/da7280.c @@ -1334,7 +1334,7 @@ static int da7280_probe(struct i2c_clien ret = devm_request_threaded_irq(dev, client->irq, NULL, da7280_irq_handler, - DA7280_IRQ_FLAGS, + DA7280_IRQ_FLAGS | IRQF_ONESHOT, "da7280-haptics", haptics); if (ret != 0) { dev_err(dev,