From: Rob Herring <robh@kernel.org>
To: Wendy Liang <wendy.liang@xilinx.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
michal.simek@xilinx.com, robh+dt@kernel.org,
mark.rutland@arm.com, rajan.vaja@xilinx.com, jollys@xilinx.com,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Wendy Liang <jliang@xilinx.com>
Subject: Re: [PATCH 7/7] Documentation: devicetree: Add Xilinx R5 rproc binding
Date: Fri, 17 Aug 2018 09:09:48 -0600 [thread overview]
Message-ID: <20180817150948.GA20845@rob-hp-laptop> (raw)
In-Reply-To: <1534403190-28523-8-git-send-email-jliang@xilinx.com>
Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.
On Thu, 16 Aug 2018 00:06:30 -0700, Wendy Liang wrote:
> Add device tree binding for Xilinx Cortex-r5 remoteproc.
>
> Signed-off-by: Wendy Liang <jliang@xilinx.com>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> .../remoteproc/xlnx,zynqmp-r5-remoteproc.txt | 81 ++++++++++++++++++++++
> 1 file changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt
>
next prev parent reply other threads:[~2018-08-17 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 7:06 [PATCH 0/7] Add Xilinx ZynqMP R5 remoteproc driver Wendy Liang
2018-08-16 7:06 ` [PATCH 1/7] firmware: xlnx-zynqmp: Add RPU ioctl enums Wendy Liang
2018-08-16 7:06 ` [PATCH 2/7] firmware: xlnx-zynqmp: Add request ack enums Wendy Liang
2018-08-16 7:06 ` [PATCH 3/7] firmware: xilinx-zynqmp: Add request access capability macro Wendy Liang
2018-08-16 7:06 ` [PATCH 4/7] firmware: xlnx-zynqmp: Add request/release node Wendy Liang
2018-08-16 7:06 ` [PATCH 5/7] firmware: xlnx-zynqmp: Add shutdown/wakeup request Wendy Liang
2018-08-16 7:06 ` [PATCH 6/7] remoteproc: Add Xilinx ZynqMP R5 remoteproc Wendy Liang
2018-08-24 16:26 ` Wendy Liang
2018-09-10 17:16 ` Wendy Liang
2018-09-10 20:24 ` Loic PALLARDY
2018-09-10 22:09 ` Jiaying Liang
2018-09-11 7:30 ` Loic PALLARDY
2018-10-06 5:44 ` Bjorn Andersson
2018-08-16 7:06 ` [PATCH 7/7] Documentation: devicetree: Add Xilinx R5 rproc binding Wendy Liang
2018-08-17 15:09 ` Rob Herring [this message]
2018-08-20 5:54 ` Wendy Liang
2018-08-17 16:31 ` Moritz Fischer
2018-08-20 5:55 ` Wendy Liang
2018-10-06 5:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817150948.GA20845@rob-hp-laptop \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jliang@xilinx.com \
--cc=jollys@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=ohad@wizery.com \
--cc=rajan.vaja@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=wendy.liang@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox