From: Rob Herring <robh@kernel.org>
To: Roy Im <roy.im.opensource@diasemi.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Support Opensource <support.opensource@diasemi.com>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] Documentation: devicetree: input: new binding for da7280
Date: Fri, 17 Aug 2018 09:10:00 -0600 [thread overview]
Message-ID: <20180817151000.GF20845@rob-hp-laptop> (raw)
In-Reply-To: <6fe6130443ab72ef8fa0e95da6a2e0d63c2ec1d7.1534468025.git.Roy.Im@diasemi.com>
Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.
On Fri, 17 Aug 2018 10:07:04 +0900, Roy Im wrote:
>
> from: Roy Im <roy.im.opensource@diasemi.com>
>
> Add device tree binding information for DA7280 haptic driver.
> Example bindings for DA7280 are added.
>
> Signed-off-by: Roy Im <roy.im.opensource@diasemi.com>
>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> v2: No changes
>
>
> .../devicetree/bindings/input/dlg,da7280.txt | 91 ++++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/dlg,da7280.txt
>
next prev parent reply other threads:[~2018-08-17 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 1:07 [PATCH V2 0/3] da7280: haptic driver submission Roy Im
2018-08-17 1:07 ` [PATCH V2 2/3] Documentation: devicetree: input: new binding for da7280 Roy Im
2018-08-17 15:10 ` Rob Herring [this message]
2018-08-17 1:07 ` [PATCH V2 1/3] MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms Roy Im
2018-08-17 1:07 ` [PATCH V2 3/3] Input: new da7280 haptic driver Roy Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817151000.GF20845@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=roy.im.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox