Re: [PATCH v3 2/2] i2c: Add Qualcomm CCI I2C driver

[Bjorn Andersson <bjorn.andersson@linaro.org>]

On Fri 17 Aug 05:41 PDT 2018, Vinod wrote:

> On 07-08-18, 10:00, Vinod wrote:
> > On 06-08-18, 11:45, Bjorn Andersson wrote:
> 
> > > The dt binding mentions that a power domain is required for v1.4, but
> > > there's no support for this in the driver.
> > 
> > I will check that, yes it is not handled in the driver we have
> 
> So I discussed this with Todor and found that __genpd_dev_pm_attach in
> drivers/base/power/domain.c handles the "power-domain" binding.
> 
> I do not think driver needs to do anything here, this seems handled in
> core and we need to provide binding, FWIW, the 8996 doesn't work without
> this
> 

Right, the power-domain will be picked up and afaict will be turned on
as it's attached to the device during probe of the platform driver. So
you don't need to do anything additionally to make it work.

But I suggest that you follow up with a patch adding runtime pm support
so that the associated power domain will be disabled when the bus is not
in use.

Regards,
Bjorn