From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 00/19] IOMMU: Tegra GART driver clean up and optimization
Date: Sat, 18 Aug 2018 18:54:11 +0300 [thread overview]
Message-ID: <20180818155430.5586-1-digetx@gmail.com> (raw)
Hello,
In the previous iteration Thierry Reding suggested that it is better to
break/change GART's device-tree ABI in order to integrate it with Memory
Controller without much churning. So this series now includes the device
tree changes.
After making GART to disallow more than one active IOMMU domain at a time,
I realized that the domain clients managing code has a few significant bugs
and now they are fixed. During the bugs squashing, I found that drivers code
require a major cleanup and hence there are now couple more patches that make
the code less tangled and easier to maintain as a result.
Changelog:
v3: Memory Controller integration part has been reworked and now GART's
device-tree binding is changed. Adding Rob Herring for the device-tree
changes reviewing.
GART now disallows more than one active domain at a time.
Fixed "spinlock recursion", "NULL pointer dereference" and "detaching
of all devices from inactive domains".
New code-refactoring patches.
The previously standalone patch "memory: tegra: Don't invoke Tegra30+
specific memory timing setup on Tegra20" is now included into this
series because there is a dependency on that patch and it wasn't applied
yet.
v2: Addressed review comments from Robin Murphy to v1 by moving devices
iommu_fwspec check to gart_iommu_add_device().
Dropped the "Provide single domain and group for all devices" patch from
the series for now because after some more considering it became not
exactly apparent whether that is what we need, that was also suggested
by Robin Murphy in the review comment. Maybe something like a runtime
IOMMU usage for devices would be a better solution, allowing to implement
transparent context switching of virtual IOMMU domains.
Some very minor code cleanups, reworded commit messages.
Dmitry Osipenko (19):
iommu/tegra: gart: Remove pr_fmt and clean up includes
iommu/tegra: gart: Clean up driver probe errors handling
iommu/tegra: gart: Ignore devices without IOMMU phandle in DT
iommu: Introduce iotlb_sync_map callback
iommu/tegra: gart: Optimize mapping / unmapping performance
dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc
ARM: dts: tegra20: Update Memory Controller node to the new binding
memory: tegra: Don't invoke Tegra30+ specific memory timing setup on
Tegra20
memory: tegra: Adapt to Tegra20 device-tree binding changes
memory: tegra: Read client ID on GART page fault
iommu/tegra: gart: Integrate with Memory Controller driver
iommu/tegra: gart: Fix spinlock recursion
iommu/tegra: gart: Fix NULL pointer dereference
iommu/tegra: gart: Allow only one active domain at a time
iommu/tegra: gart: Don't use managed resources
iommu/tegra: gart: Prepend error/debug messages with "GART:"
iommu/tegra: gart: Don't detach devices from inactive domains
iommu/tegra: gart: Simplify clients-tracking code
iommu/tegra: gart: Perform code refactoring
.../bindings/iommu/nvidia,tegra20-gart.txt | 14 -
.../memory-controllers/nvidia,tegra20-mc.txt | 23 +-
arch/arm/boot/dts/tegra20.dtsi | 13 +-
drivers/iommu/Kconfig | 1 +
drivers/iommu/iommu.c | 8 +-
drivers/iommu/tegra-gart.c | 466 +++++++-----------
drivers/memory/tegra/mc.c | 83 +++-
drivers/memory/tegra/mc.h | 6 -
include/linux/iommu.h | 1 +
include/soc/tegra/mc.h | 29 +-
10 files changed, 287 insertions(+), 357 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/iommu/nvidia,tegra20-gart.txt
--
2.18.0
next reply other threads:[~2018-08-18 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 15:54 Dmitry Osipenko [this message]
2018-08-18 15:54 ` [PATCH v3 01/19] iommu/tegra: gart: Remove pr_fmt and clean up includes Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 03/19] iommu/tegra: gart: Ignore devices without IOMMU phandle in DT Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 05/19] iommu/tegra: gart: Optimize mapping / unmapping performance Dmitry Osipenko
[not found] ` <20180818155430.5586-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-18 15:54 ` [PATCH v3 02/19] iommu/tegra: gart: Clean up driver probe errors handling Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 04/19] iommu: Introduce iotlb_sync_map callback Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 06/19] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc Dmitry Osipenko
2018-08-20 19:12 ` Rob Herring
2018-08-20 19:27 ` Dmitry Osipenko
[not found] ` <b46cac22-9b31-9aa7-7eca-4725156346bb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-20 19:35 ` Dmitry Osipenko
[not found] ` <4538309b-fcb3-73ee-04e3-6cefcedd376d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-28 10:47 ` Thierry Reding
2018-08-28 13:09 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 07/19] ARM: dts: tegra20: Update Memory Controller node to the new binding Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 08/19] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 09/19] memory: tegra: Adapt to Tegra20 device-tree binding changes Dmitry Osipenko
2018-09-03 21:06 ` Marcel Ziswiler
2018-09-04 8:56 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 10/19] memory: tegra: Read client ID on GART page fault Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 11/19] iommu/tegra: gart: Integrate with Memory Controller driver Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 12/19] iommu/tegra: gart: Fix spinlock recursion Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 13/19] iommu/tegra: gart: Fix NULL pointer dereference Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 14/19] iommu/tegra: gart: Allow only one active domain at a time Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 15/19] iommu/tegra: gart: Don't use managed resources Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 16/19] iommu/tegra: gart: Prepend error/debug messages with "GART:" Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 17/19] iommu/tegra: gart: Don't detach devices from inactive domains Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 18/19] iommu/tegra: gart: Simplify clients-tracking code Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 19/19] iommu/tegra: gart: Perform code refactoring Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818155430.5586-1-digetx@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).