From: Dmitry Osipenko <digetx@gmail.com>
To: Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>
Cc: iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 09/19] memory: tegra: Adapt to Tegra20 device-tree binding changes
Date: Sat, 18 Aug 2018 18:54:20 +0300 [thread overview]
Message-ID: <20180818155430.5586-10-digetx@gmail.com> (raw)
In-Reply-To: <20180818155430.5586-1-digetx@gmail.com>
The tegra20-mc DT binding has been changed, GART has been squashed
into Memory Controller and now the clock property is mandatory for
Tegra20. Adapt driver the to DT changes.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/tegra/mc.c | 19 +++++++------------
drivers/memory/tegra/mc.h | 6 ------
include/soc/tegra/mc.h | 2 +-
3 files changed, 8 insertions(+), 19 deletions(-)
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index e56862495f36..3bf3138769f4 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -638,24 +638,19 @@ static int tegra_mc_probe(struct platform_device *pdev)
if (IS_ERR(mc->regs))
return PTR_ERR(mc->regs);
+ mc->clk = devm_clk_get(&pdev->dev, "mc");
+ if (IS_ERR(mc->clk)) {
+ dev_err(&pdev->dev, "failed to get MC clock: %ld\n",
+ PTR_ERR(mc->clk));
+ return PTR_ERR(mc->clk);
+ }
+
#ifdef CONFIG_ARCH_TEGRA_2x_SOC
if (mc->soc == &tegra20_mc_soc) {
- res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- mc->regs2 = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(mc->regs2))
- return PTR_ERR(mc->regs2);
-
isr = tegra20_mc_irq;
} else
#endif
{
- mc->clk = devm_clk_get(&pdev->dev, "mc");
- if (IS_ERR(mc->clk)) {
- dev_err(&pdev->dev, "failed to get MC clock: %ld\n",
- PTR_ERR(mc->clk));
- return PTR_ERR(mc->clk);
- }
-
err = tegra_mc_setup_latency_allowance(mc);
if (err < 0) {
dev_err(&pdev->dev, "failed to setup latency allowance: %d\n",
diff --git a/drivers/memory/tegra/mc.h b/drivers/memory/tegra/mc.h
index 01065f12ebeb..9856f085e487 100644
--- a/drivers/memory/tegra/mc.h
+++ b/drivers/memory/tegra/mc.h
@@ -26,18 +26,12 @@
static inline u32 mc_readl(struct tegra_mc *mc, unsigned long offset)
{
- if (mc->regs2 && offset >= 0x24)
- return readl(mc->regs2 + offset - 0x3c);
-
return readl(mc->regs + offset);
}
static inline void mc_writel(struct tegra_mc *mc, u32 value,
unsigned long offset)
{
- if (mc->regs2 && offset >= 0x24)
- return writel(value, mc->regs2 + offset - 0x3c);
-
writel(value, mc->regs + offset);
}
diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
index b43f37fea096..db5bfdf589b4 100644
--- a/include/soc/tegra/mc.h
+++ b/include/soc/tegra/mc.h
@@ -144,7 +144,7 @@ struct tegra_mc_soc {
struct tegra_mc {
struct device *dev;
struct tegra_smmu *smmu;
- void __iomem *regs, *regs2;
+ void __iomem *regs;
struct clk *clk;
int irq;
--
2.18.0
next prev parent reply other threads:[~2018-08-18 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 15:54 [PATCH v3 00/19] IOMMU: Tegra GART driver clean up and optimization Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 01/19] iommu/tegra: gart: Remove pr_fmt and clean up includes Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 03/19] iommu/tegra: gart: Ignore devices without IOMMU phandle in DT Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 05/19] iommu/tegra: gart: Optimize mapping / unmapping performance Dmitry Osipenko
[not found] ` <20180818155430.5586-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-18 15:54 ` [PATCH v3 02/19] iommu/tegra: gart: Clean up driver probe errors handling Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 04/19] iommu: Introduce iotlb_sync_map callback Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 06/19] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc Dmitry Osipenko
2018-08-20 19:12 ` Rob Herring
2018-08-20 19:27 ` Dmitry Osipenko
[not found] ` <b46cac22-9b31-9aa7-7eca-4725156346bb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-20 19:35 ` Dmitry Osipenko
[not found] ` <4538309b-fcb3-73ee-04e3-6cefcedd376d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-28 10:47 ` Thierry Reding
2018-08-28 13:09 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 07/19] ARM: dts: tegra20: Update Memory Controller node to the new binding Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 08/19] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko [this message]
2018-09-03 21:06 ` [PATCH v3 09/19] memory: tegra: Adapt to Tegra20 device-tree binding changes Marcel Ziswiler
2018-09-04 8:56 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 10/19] memory: tegra: Read client ID on GART page fault Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 11/19] iommu/tegra: gart: Integrate with Memory Controller driver Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 12/19] iommu/tegra: gart: Fix spinlock recursion Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 13/19] iommu/tegra: gart: Fix NULL pointer dereference Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 14/19] iommu/tegra: gart: Allow only one active domain at a time Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 15/19] iommu/tegra: gart: Don't use managed resources Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 16/19] iommu/tegra: gart: Prepend error/debug messages with "GART:" Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 17/19] iommu/tegra: gart: Don't detach devices from inactive domains Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 18/19] iommu/tegra: gart: Simplify clients-tracking code Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 19/19] iommu/tegra: gart: Perform code refactoring Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818155430.5586-10-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).