From: Vinod <vkoul@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Todor Tomov <todor.tomov@linaro.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: i2c: Add binding for Qualcomm CCI I2C controller
Date: Tue, 21 Aug 2018 14:58:03 +0530 [thread overview]
Message-ID: <20180821092803.GC2388@vkoul-mobl> (raw)
In-Reply-To: <20180820181859.GA3439@bogus>
On 20-08-18, 13:18, Rob Herring wrote:
> On Mon, Aug 20, 2018 at 12:09:52PM +0530, Vinod Koul wrote:
> > +PROPERTIES:
> > +
> > +- compatible:
> > + Usage: required
> > + Value type: <string>
> > + Definition: must be one of:
> > + "qcom,msm-8916-cci"
> > + "qcom,msm-8996-cci"
>
> I think everywhere else is 'msm8916' and 'msm8996'.
Quick grep told me that is the case, so will update.
> > +SUBNODES:
> > +
> > +The CCI provides I2C masters for one or two i2c busses, described as
> > +subdevices named "i2c-bus0" and "i2c-bus1".
>
> Use a unit-address and reg property with 0 and 1 here.
Am not sure I understood that properly, still learning DT nuisances,
care to elaborate a bit please.
> With those fixed,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Great, thanks for the review.
--
~Vinod
next prev parent reply other threads:[~2018-08-21 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 6:39 [PATCH v4 0/2] i2c: Add support for Qcom CCI I2C controller Vinod Koul
2018-08-20 6:39 ` [PATCH v4 1/2] dt-bindings: i2c: Add binding for Qualcomm " Vinod Koul
2018-08-20 18:18 ` Rob Herring
2018-08-21 9:28 ` Vinod [this message]
2018-08-21 13:11 ` Rob Herring
2018-08-21 13:12 ` Rob Herring
2018-08-21 16:00 ` Vinod
2018-08-20 6:39 ` [PATCH v4 2/2] i2c: Add Qualcomm CCI I2C driver Vinod Koul
2018-08-24 7:30 ` Stephen Boyd
2018-08-24 10:16 ` Vinod
2018-08-27 19:19 ` Stephen Boyd
2018-08-28 3:38 ` Vinod
2018-09-20 19:39 ` Ricardo Ribalda Delgado
2018-09-21 15:36 ` Vinod
2018-09-21 15:43 ` Todor Tomov
2018-09-22 22:02 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821092803.GC2388@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=robh@kernel.org \
--cc=todor.tomov@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).