From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 4/4] remoteproc: qcom: q6v5-pil: Add PDC restart for modem on SDM845 SoCs Date: Tue, 21 Aug 2018 15:33:39 -0700 Message-ID: <20180821223339.GA2523@minitux> References: <20180727152811.15258-1-sibis@codeaurora.org> <20180727152811.15258-4-sibis@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180727152811.15258-4-sibis@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Sibi Sankar Cc: p.zabel@pengutronix.de, robh+dt@kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, ohad@wizery.com, mark.rutland@arm.com, sricharan@codeaurora.org, akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org, tsoni@codeaurora.org List-Id: devicetree@vger.kernel.org On Fri 27 Jul 08:28 PDT 2018, Sibi Sankar wrote: > In the presence of a PDC block working with subsystem RSC, > assert/deassert PDC restart in modem start/stop path. > > Signed-off-by: Sibi Sankar > --- > .../bindings/remoteproc/qcom,q6v5.txt | 4 +++ > drivers/remoteproc/qcom_q6v5_pil.c | 27 ++++++++++++++++--- > 2 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > index 601dd9f389aa..124fb1dc6fb8 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > @@ -51,6 +51,8 @@ on the Qualcomm Hexagon core. > Usage: required > Value type: > Definition: reference to the reset-controller for the modem sub-system > + reference to the list of 2 reset-controllers for the modem > + sub-system on SDM845 SoCs > reference to the list of 3 reset-controllers for the > wcss sub-system > > @@ -58,6 +60,8 @@ on the Qualcomm Hexagon core. > Usage: required > Value type: > Definition: must be "mss_restart" for the modem sub-system > + Definition: must be "mss_restart", "pdc_restart" for the modem > + sub-system on SDM845 SoCs > Definition: must be "wcss_aon_reset", "wcss_reset", "wcss_q6_reset" > for the wcss syb-system Seems like we got an additional "Definition:" added here as we added the wcss. Please don't add another one. The rest looks good. Regards, Bjorn