From: Segher Boessenkool <segher@kernel.crashing.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rob Herring <robh@kernel.org>, Kumar Gala <kumar.gala@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
devicetree-spec@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
devicetree@vger.kernel.org, Grant Likely <grant.likely@arm.com>,
Frank Rowand <frowand.list@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: DT case sensitivity
Date: Thu, 23 Aug 2018 07:19:29 -0500 [thread overview]
Message-ID: <20180823121929.GS24439@gate.crashing.org> (raw)
In-Reply-To: <3335cff2cc999c1dda58d75949ab3d12185fca79.camel@kernel.crashing.org>
On Thu, Aug 23, 2018 at 11:03:28AM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2018-08-22 at 19:47 -0500, Rob Herring wrote:
> > The default DT string handling in the kernel is node names and
> > compatibles are case insensitive and property names are case sensitive
> > (Sparc is the the only variation and is opposite). It seems only PPC
> > (and perhaps only Power Macs?) needs to support case insensitive
> > comparisons. It was probably a mistake to follow PPC for new arches
> > and we should have made everything case sensitive from the start. So I
> > have a few questions for the DT historians. :)
>
> Open Firmware itself is insensitive.
Some implementations are, yes. But those are technically broken.
> > What PPC systems are case insensitive? Can we limit that to certain systems?
>
> All PowerMacs at least, the problem is that I don't have DT images or
> access to all the historical systems (and yes some people occasionally
> still use them) to properly test a change in that area.
If one implementation does case insensitive, it will most likely just work,
because people do not make insane names differing only in case on purpose.
Now people write other things that they only test against that implementation,
and those things now only work with case-insensitive. And you do not know
without testing if anything breaks. (But the laws of big numbers are against
you here). Since there isn't really a drawback to doing case-insensitive
always, that is a much safer way forward, much less work for everyone, even
if technically the wrong thing to do :-)
Segher
next prev parent reply other threads:[~2018-08-23 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 0:47 DT case sensitivity Rob Herring
2018-08-23 1:03 ` Benjamin Herrenschmidt
2018-08-23 1:26 ` Rob Herring
2018-08-23 1:29 ` Benjamin Herrenschmidt
2018-08-23 9:02 ` Grant Likely
2018-08-23 11:43 ` Rob Herring
2018-08-23 11:47 ` Benjamin Herrenschmidt
2018-08-23 11:56 ` Grant Likely
2018-08-23 12:08 ` Rob Herring
2018-08-23 12:48 ` Grant Likely
2018-08-23 12:36 ` Segher Boessenkool
2018-08-24 15:14 ` Rob Herring
2018-08-24 16:52 ` Segher Boessenkool
2018-08-23 12:19 ` Segher Boessenkool [this message]
2018-08-23 21:49 ` Benjamin Herrenschmidt
2018-08-24 5:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823121929.GS24439@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-spec@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@arm.com \
--cc=kumar.gala@linaro.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).