From: Sudeep Holla <sudeep.holla@arm.com>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com,
robh+dt@kernel.org, Mark Rutland <mark.rutland@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linaro.org>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Shawn Guo <shawnguo@kernel.org>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Minghuan Lian <minghuan.Lian@nxp.com>,
Yuantian Tang <andy.tang@nxp.com>, Ran Wang <ran.wang_1@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Yuan Yao <yao.yuan@nxp.com>, Sumit Garg <sumit.garg@nxp.com>,
Marc Zyngier <marc.zyngier@arm.com>, Madalin Bucur <mada>
Subject: Re: [PATCH] arm64: dts: Fix various entry-method properties to reflect documentation
Date: Thu, 23 Aug 2018 16:31:10 +0100 [thread overview]
Message-ID: <20180823153110.GA19131@e107155-lin> (raw)
In-Reply-To: <113f28acbc55f64762c9f0bcefe076a811f2ed82.1535014078.git.amit.kucheria@linaro.org>
Hi Amit,
Thanks for fixing this.
On Thu, Aug 23, 2018 at 02:23:29PM +0530, Amit Kucheria wrote:
> The idle-states binding documentation[1] mentions that the
> 'entry-method' property is required on 64-bit platforms and must be
> set to "psci".
>
> commit a13f18f59d26 ("Documentation: arm: Fix typo in the idle-states
> bindings examples") attempted to fix this earlier but clearly more is
> needed.
>
In fact, I assumed I fixed things with commit 978fa436231a ("drivers:
firmware: psci: unify enable-method binding on ARM {64,32}-bit systems"),
but I was wrong. I left quite a few instances including juno dtbs.
> Fix the cpu-capacity.txt documentation that uses the incorrect value so
> we don't get copy-paste errors like these. Clarify the language in
> idle-states.txt by removing the reference to the psci bindings that
> might be causing this confusion.
>
> Finally, fix devicetrees of various boards to reflect current
> documentation.
>
> [1] Documentation/devicetree/bindings/arm/idle-states.txt (see
> idle-states node)
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/cpu-capacity.txt | 2 +-
> Documentation/devicetree/bindings/arm/idle-states.txt | 4 ++--
> arch/arm64/boot/dts/arm/juno-r1.dts | 2 +-
> arch/arm64/boot/dts/arm/juno-r2.dts | 2 +-
> arch/arm64/boot/dts/arm/juno.dts | 2 +-
For all the above files,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
How do you plan to merge ? I prefer if you can send it via arm-soc as
fixes for this cycle with all the necessary acks. Otherwise you may have
to split this to send via platform maintainers which is bit mundane.
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-08-23 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 8:53 [PATCH] arm64: dts: Fix various entry-method properties to reflect documentation Amit Kucheria
2018-08-23 15:31 ` Sudeep Holla [this message]
2018-08-23 20:02 ` Amit Kucheria
2018-08-24 15:38 ` Olof Johansson
2018-08-23 20:46 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823153110.GA19131@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=amit.kucheria@linaro.org \
--cc=andy.tang@nxp.com \
--cc=baolin.wang@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=fabio.estevam@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=minghuan.Lian@nxp.com \
--cc=orsonzhai@gmail.com \
--cc=ran.wang_1@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=sumit.garg@nxp.com \
--cc=will.deacon@arm.com \
--cc=yao.yuan@nxp.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).