From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v5 1/2] dt-bindings: leds: Add bindings for lm3697 driver Date: Fri, 24 Aug 2018 11:55:15 +0200 Message-ID: <20180824095515.GB4045@amd> References: <20180817151528.21623-1-dmurphy@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XF85m9dhOBO43t/C" Return-path: Content-Disposition: inline In-Reply-To: <20180817151528.21623-1-dmurphy@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Dan Murphy Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org List-Id: devicetree@vger.kernel.org --XF85m9dhOBO43t/C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2018-08-17 10:15:27, Dan Murphy wrote: > Add the device tree bindings for the lm3697 > LED driver for backlighting and display. >=20 > Signed-off-by: Dan Murphy Acked-by: Pavel Machek Some nits are below. > +The LM3697 11-bit LED driver provides high- > +performance backlight dimming for 1, 2, or 3 series > +LED strings while delivering up to 90% efficiency. LED core is 8-bit only... so full dynamic range can not be currently used in linux -- right? Is there any plan to change/fix that? > +This device is suitable for Display and Keypad Lighting "display and keypad lighting." > +Optional properties: > + - enable-gpios : gpio pin to enable/disable the device. Remove "." at end of sentence, for consistency. "GPIO"? > +All HVLED strings controlled by control bank A ":"? > +led-controller@36 { > + compatible =3D "ti,lm3967"; > + reg =3D <0x36>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + enable-gpios =3D <&gpio1 28 GPIO_ACTIVE_HIGH>; > + vled-supply =3D <&vbatt>; > + > + led@0 { > + reg =3D <0>; > + led-sources =3D <1 1 1>; > + label =3D "white:backlight_cluster"; > + linux,default-trigger =3D "backlight"; > + }; > +} > + > +For more product information please see the link below: > +http://www.ti.com/lit/ds/symlink/lm3697.pdf --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --XF85m9dhOBO43t/C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlt/1gMACgkQMOfwapXb+vJ7sQCfQERZBzCfSk1cLZSRcQj6SuJw o9sAn0U3Yg2Pa2vLQIQUWc/jzi5nhnTG =+Hlr -----END PGP SIGNATURE----- --XF85m9dhOBO43t/C--