Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-pwm@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver
Date: Fri, 24 Aug 2018 10:37:12 +0200	[thread overview]
Message-ID: <20180824103712.1d889f17@bbrezillon> (raw)
In-Reply-To: <1afc6d63-094b-3bff-87e9-d2354602ba76@microchip.com>

On Thu, 16 Aug 2018 10:28:54 +0200
Nicolas Ferre <nicolas.ferre@microchip.com> wrote:

> On 15/08/2018 at 22:40, Sam Ravnborg wrote:
> > Hi Lee.
> >   
> >>> +
> >>> +static const struct mfd_cell lcdc_cells[] = {
> >>> +	{
> >>> +		.name = "atmel-lcdc-pwm",
> >>> +		.of_compatible = "atmel,lcdc-pwm",
> >>> +	},
> >>> +	{
> >>> +		.name = "atmel-lcdc-dc",
> >>> +		.of_compatible = "atmel,lcdc-display-controller",
> >>> +	},
> >>> +};  
> >>
> >> Will you be adding any more devices, or is this the entirety of the
> >> device?  If the latter, I suggest that this doesn't warrant being an
> >> MFD.  
> > Thats it. And others agree with you that this is not a good approach.
> > So in v2 there will be no MFD.
> > 
> > Thanks for confirming that the non-mfd way is the better approach.  
> 
> MFD approach would have had the benefit of keeping this driver series 
> architecture close to the HLCD one. This would have been easier to 
> understand and use one SoC or another one from the AT91 product line....
> 
> Anyway, I'd wait for Boris' feedback for making a decision.

If possible I'd like to keep the MFD approach, but let's see if we can
have a single node in the DT instead of one for the MFD and 2 child
nodes (for the display controller and the PWM).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel