From: Pavel Machek <pavel@ucw.cz>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
daniel.thompson@linaro.org, b.zolnierkie@samsung.com,
jingoohan1@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, jacek.anaszewski@gmail.com,
linux-arm-msm@vger.kernel.org, lee.jones@linaro.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH V5 3/8] backlight: qcom-wled: Add new properties for PMI8998
Date: Mon, 27 Aug 2018 12:01:43 +0200 [thread overview]
Message-ID: <20180827100143.GE31905@amd> (raw)
In-Reply-To: <1535106467-17843-4-git-send-email-kgunda@codeaurora.org>
[-- Attachment #1.1: Type: text/plain, Size: 1642 bytes --]
Hi!
On Fri 2018-08-24 15:57:42, Kiran Gunda wrote:
> Update the bindings with the new properties used for
> PMI8998.
> Changes from V3:
> - Removed the default values.
Why?
> +- qcom,current-limit-microamp
> + Usage: optional
> + Value type: <u32>
> + Definition: uA; per-string current limit; value from 0 to 30000 with
> + 2500 uA step.
>
> - qcom,current-boost-limit
> Usage: optional
> Value type: <u32>
> Definition: mA; boost current limit.
> For pm8941: one of: 105, 385, 525, 805, 980, 1260, 1400,
> - 1680. Default: 805 mA
> + 1680.
> For pmi8998: one of: 105, 280, 450, 620, 970, 1150, 1300,
> - 1500. Default: 970 mA
> + 1500.
>
I'd say that optional properties should list default values...?
> - qcom,ovp
> Usage: optional
> Value type: <u32>
> Definition: V; Over-voltage protection limit; one of:
> - 27, 29, 32, 35. default: 29V
> + 27, 29, 32, 35.
> This property is supported only for PM8941.
>
Same here.
> +- qcom,ovp-millivolt
> + Usage: optional
> + Value type: <u32>
> + Definition: mV; Over-voltage protection limit;
> + For pmi8998: one of 18100, 19600, 29600, 31100
> + If this property is not specified for PM8941, it
> + falls back to "qcom,ovp" property.
> +
"voltage-limit-millivolt"? "ovp" is not really well known acronym.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-27 10:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 10:27 [PATCH V5 0/8] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-08-24 10:27 ` [PATCH V5 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-08-27 9:49 ` Pavel Machek
2018-08-24 10:27 ` [PATCH V5 2/8] backlight: qcom-wled: restructure the qcom-wled bindings Kiran Gunda
2018-08-27 9:52 ` Pavel Machek
2018-08-24 10:27 ` [PATCH V5 3/8] backlight: qcom-wled: Add new properties for PMI8998 Kiran Gunda
2018-08-27 10:01 ` Pavel Machek [this message]
2018-08-29 5:52 ` kgunda
2018-08-24 10:27 ` [PATCH V5 4/8] backlight: qcom-wled: Rename PM8941* to WLED3 Kiran Gunda
2018-08-27 10:04 ` Pavel Machek
2018-08-27 15:04 ` Bjorn Andersson
2018-08-24 10:27 ` [PATCH V5 5/8] backlight: qcom-wled: Restructure the driver for WLED3 Kiran Gunda
2018-08-27 10:09 ` Pavel Machek
2018-08-29 7:10 ` kgunda
2018-08-24 10:27 ` [PATCH V5 6/8] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-08-24 10:27 ` [PATCH V5 7/8] backlight: qcom-wled: add support for short circuit handling Kiran Gunda
2018-08-24 10:27 ` [PATCH V5 8/8] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-08-27 14:54 ` Bjorn Andersson
2018-08-29 7:13 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827100143.GE31905@amd \
--to=pavel@ucw.cz \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).